Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2505493004: Wired up vrdisplayactivate/deactivate (Closed)

Created:
4 years, 1 month ago by bajones
Modified:
4 years, 1 month ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, haraken, Aaron Boodman, feature-vr-reviews_chromium.org, blink-reviews, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wired up vrdisplayactivate/deactivate These events allows pages to automatically enter or exit WebVR presentation when the HMD indicates that it's appropriate (such as when the user puts it on or when a mobile device is placed in the headset.) BUG=389343 Committed: https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c Cr-Commit-Position: refs/heads/master@{#432339}

Patch Set 1 #

Patch Set 2 : Fixed ability to actually enter VR mode with the current ToT #

Patch Set 3 : Fixed missing return (shouldn't get there) #

Patch Set 4 : Again with the upstream issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -53 lines) Patch
M device/vr/android/gvr/gvr_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/vr/android/gvr/gvr_device_provider.cc View 3 1 chunk +2 lines, -2 lines 0 comments Download
M device/vr/vr_device.h View 1 chunk +5 lines, -3 lines 0 comments Download
M device/vr/vr_device.cc View 2 chunks +16 lines, -6 lines 0 comments Download
M device/vr/vr_service.mojom View 3 chunks +12 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.cpp View 1 3 chunks +9 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 1 1 chunk +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 1 7 chunks +31 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplayEvent.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplayEvent.cpp View 1 2 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
bajones
mthiesse@ or klausw@: Please take a look at the device/vr and modules/vr. mkwst@ or dcheng@: ...
4 years, 1 month ago (2016-11-15 18:52:58 UTC) #2
mthiesse
lgtm
4 years, 1 month ago (2016-11-15 18:56:29 UTC) #3
dcheng
mojom lgtm
4 years, 1 month ago (2016-11-15 22:23:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505493004/60001
4 years, 1 month ago (2016-11-15 23:29:57 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-16 01:29:34 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 01:34:29 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1fe0f40829f0e14e7af0721d5047bd62ba1dd07c
Cr-Commit-Position: refs/heads/master@{#432339}

Powered by Google App Engine
This is Rietveld 408576698