Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2501063002: Suppress findbugs warnings on Chromium for syncronized methods (Closed)

Created:
4 years, 1 month ago by Yusuf
Modified:
4 years, 1 month ago
Reviewers:
Ian Wen, Benoit L
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Suppress findbugs warnings on Chromium for syncronized methods Have to suppress warnings with annotation to roll DEPS and land on Chromium. Committed: https://github.com/GoogleChrome/custom-tabs-client/commit/6831edaa4f079d2d033d714c9a4df4b3e16feb97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M customtabs/src/android/support/customtabs/CustomTabsCallback.java View 3 chunks +4 lines, -0 lines 0 comments Download
M customtabs/src/android/support/customtabs/CustomTabsClient.java View 3 chunks +4 lines, -0 lines 0 comments Download
M customtabs/src/android/support/customtabs/CustomTabsSession.java View 2 chunks +3 lines, -0 lines 0 comments Download
M customtabs/src/android/support/customtabs/CustomTabsSessionToken.java View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yusuf
4 years, 1 month ago (2016-11-14 18:32:24 UTC) #2
Ian Wen
lgtm
4 years, 1 month ago (2016-11-14 19:20:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501063002/1
4 years, 1 month ago (2016-11-14 19:20:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/GoogleChrome/custom-tabs-client/commit/6831edaa4f079d2d033d714c9a4df4b3e16feb97
4 years, 1 month ago (2016-11-14 19:21:14 UTC) #7
Yusuf
4 years, 1 month ago (2016-11-14 20:26:35 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2495423003/ by yusufo@chromium.org.

The reason for reverting is: Broke compile.

Powered by Google App Engine
This is Rietveld 408576698