Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Unified Diff: customtabs/src/android/support/customtabs/CustomTabsSessionToken.java

Issue 2501063002: Suppress findbugs warnings on Chromium for syncronized methods (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « customtabs/src/android/support/customtabs/CustomTabsSession.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: customtabs/src/android/support/customtabs/CustomTabsSessionToken.java
diff --git a/customtabs/src/android/support/customtabs/CustomTabsSessionToken.java b/customtabs/src/android/support/customtabs/CustomTabsSessionToken.java
index d20921737b7877613ea3327decd6ef2a63890749..794c301ddde944fe11f4a2ece9b3fbc34a426eec 100644
--- a/customtabs/src/android/support/customtabs/CustomTabsSessionToken.java
+++ b/customtabs/src/android/support/customtabs/CustomTabsSessionToken.java
@@ -24,6 +24,8 @@ import android.os.RemoteException;
import android.support.v4.app.BundleCompat;
import android.util.Log;
+import org.chromium.base.annotations.SuppressFBWarnings;
+
/**
* Wrapper class that can be used as a unique identifier for a session. Also contains an accessor
* for the {@link CustomTabsCallback} for the session if there was any.
@@ -90,6 +92,7 @@ public class CustomTabsSessionToken {
}
}
+ @SuppressFBWarnings("CHROMIUM_SYNCHRONIZED_METHOD")
@Override
public synchronized void onMessageChannelReady(Uri origin, Bundle extras) {
try {
@@ -99,6 +102,7 @@ public class CustomTabsSessionToken {
}
}
+ @SuppressFBWarnings("CHROMIUM_SYNCHRONIZED_METHOD")
@Override
public synchronized void onPostMessage(String message, Bundle extras) {
try {
« no previous file with comments | « customtabs/src/android/support/customtabs/CustomTabsSession.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698