Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: customtabs/src/android/support/customtabs/CustomTabsClient.java

Issue 2501063002: Suppress findbugs warnings on Chromium for syncronized methods (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: customtabs/src/android/support/customtabs/CustomTabsClient.java
diff --git a/customtabs/src/android/support/customtabs/CustomTabsClient.java b/customtabs/src/android/support/customtabs/CustomTabsClient.java
index 84cf46374ca39798272f7503a1646ff881945e3d..a5047855a5008b98faf621aa45bb62768db7900f 100644
--- a/customtabs/src/android/support/customtabs/CustomTabsClient.java
+++ b/customtabs/src/android/support/customtabs/CustomTabsClient.java
@@ -30,6 +30,8 @@ import android.os.RemoteException;
import android.support.annotation.Nullable;
import android.text.TextUtils;
+import org.chromium.base.annotations.SuppressFBWarnings;
+
import java.util.ArrayList;
import java.util.List;
@@ -195,6 +197,7 @@ public class CustomTabsClient {
});
}
+ @SuppressFBWarnings("CHROMIUM_SYNCHRONIZED_METHOD")
@Override
public synchronized void onMessageChannelReady(final Uri origin, final Bundle extras) {
if (callback == null) return;
@@ -206,6 +209,7 @@ public class CustomTabsClient {
});
}
+ @SuppressFBWarnings("CHROMIUM_SYNCHRONIZED_METHOD")
@Override
public synchronized void onPostMessage(final String message, final Bundle extras) {
if (callback == null) return;

Powered by Google App Engine
This is Rietveld 408576698