Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: customtabs/src/android/support/customtabs/CustomTabsCallback.java

Issue 2501063002: Suppress findbugs warnings on Chromium for syncronized methods (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | customtabs/src/android/support/customtabs/CustomTabsClient.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: customtabs/src/android/support/customtabs/CustomTabsCallback.java
diff --git a/customtabs/src/android/support/customtabs/CustomTabsCallback.java b/customtabs/src/android/support/customtabs/CustomTabsCallback.java
index 261fc870e30196ca2c9036eea9886210d359b04e..0f3f40ac626e20e5d34cf938b793b907d7d3df7b 100644
--- a/customtabs/src/android/support/customtabs/CustomTabsCallback.java
+++ b/customtabs/src/android/support/customtabs/CustomTabsCallback.java
@@ -19,6 +19,8 @@ package android.support.customtabs;
import android.net.Uri;
import android.os.Bundle;
+import org.chromium.base.annotations.SuppressFBWarnings;
+
/**
* A callback class for custom tabs client to get messages regarding events in their custom tabs. In
* the implementation, all callbacks are sent to the UI thread for the client.
@@ -71,6 +73,7 @@ public class CustomTabsCallback {
* from this {@link CustomTabsSession}.
* @param extras Reserved for future use.
*/
+ @SuppressFBWarnings("CHROMIUM_SYNCHRONIZED_METHOD")
public synchronized void onMessageChannelReady(Uri origin, Bundle extras) {}
/**
@@ -82,6 +85,7 @@ public class CustomTabsCallback {
* @param message The message sent.
* @param extras Reserved for future use.
*/
+ @SuppressFBWarnings("CHROMIUM_SYNCHRONIZED_METHOD")
public synchronized void onPostMessage(String message, Bundle extras) {}
/**
« no previous file with comments | « no previous file | customtabs/src/android/support/customtabs/CustomTabsClient.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698