Replace wrapUnique(new T(args)) by makeUnique<T>(args) in Blink

Replace wrapUnique(new T(args)) by makeUnique<T>(args) in Blink

This is a follow-up on http://crrev.com/2455313003.
WTF::MakeUnique is based on base::MakeUnique and has the same interface as std::make_unique

Before:
 std::unique_ptr<EightyColumnsFtw> eighty(new EightyColumnsFtw(100));
After:
 auto eighty = MakeUnique<EightyColumnsFtw>(100);

BUG=662304
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/fd4636a8119d2b6a6f92b96011ff860b57963683
Cr-Commit-Position: refs/heads/master@{#432016}

[Gleb Lanbin, 2016-11-12 15:40:52]

Description was changed from

==========
Replace wrapUnique(new T(args)) by makeUnique<T>(args) in Blink

This is a follow-up on http://crrev.com/2455313003.
WTF::MakeUnique is based on base::MakeUnique and has the same interface as
std::make_unique

Before:
 std::unique_ptr<EightyColumnsFtw> eighty(new EightyColumnsFtw(100));
After:
 auto eighty = MakeUnique<EightyColumnsFtw>(100);

BUG=662304
==========

to

==========
Replace wrapUnique(new T(args)) by makeUnique<T>(args) in Blink

This is a follow-up on http://crrev.com/2455313003.
WTF::MakeUnique is based on base::MakeUnique and has the same interface as
std::make_unique

Before:
 std::unique_ptr<EightyColumnsFtw> eighty(new EightyColumnsFtw(100));
After:
 auto eighty = MakeUnique<EightyColumnsFtw>(100);

BUG=662304
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Gleb Lanbin, 2016-11-12 15:40:53]

Description was changed from

==========
Replace wrapUnique(new T(args)) by makeUnique<T>(args) in Blink

This is a follow-up on http://crrev.com/2455313003.
WTF::MakeUnique is based on base::MakeUnique and has the same interface as
std::make_unique

Before:
 std::unique_ptr<EightyColumnsFtw> eighty(new EightyColumnsFtw(100));
After:
 auto eighty = MakeUnique<EightyColumnsFtw>(100);

BUG=662304
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Replace wrapUnique(new T(args)) by makeUnique<T>(args) in Blink

This is a follow-up on http://crrev.com/2455313003.
WTF::MakeUnique is based on base::MakeUnique and has the same interface as
std::make_unique

Before:
 std::unique_ptr<EightyColumnsFtw> eighty(new EightyColumnsFtw(100));
After:
 auto eighty = MakeUnique<EightyColumnsFtw>(100);

BUG=662304
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Gleb Lanbin, 2016-11-12 15:40:58]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-12 15:41:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 16:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-12 16:34:37]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Gleb Lanbin, 2016-11-12 19:16:44]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-12 19:16:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 20:41:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-12 20:41:58]

Dry run: This issue passed the CQ dry run.

[Gleb Lanbin, 2016-11-12 21:12:28]

Patchset #1 (id:1) has been deleted

[Gleb Lanbin, 2016-11-12 21:12:48]

glebl@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-11-14 01:46:05]

LGTM

https://codereview.chromium.org/2494333002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp (right):

https://codereview.chromium.org/2494333002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:97: return
WTF::makeUnique<EmptyDataReader>(client);

Drop redundant WTF::. The same comment for other places in this CL.

[haraken, 2016-11-14 01:46:49]

Also can we remove wrapUnique from wtf/PtrUtils.h?

[Yuta Kitamura, 2016-11-14 08:57:44]

On 2016/11/14 01:46:49, haraken wrote:
> Also can we remove wrapUnique from wtf/PtrUtils.h?

No, I don't think this is possible because of our traditional
"static create() function" idiom.

[Yuta Kitamura, 2016-11-14 08:58:09]

yutak@chromium.org changed reviewers:
+ yutak@chromium.org

[Yuta Kitamura, 2016-11-14 08:58:10]

This patch LGTM.

[Gleb Lanbin, 2016-11-14 17:19:42]

On 2016/11/14 01:46:05, haraken wrote:
> LGTM
> 
>
https://codereview.chromium.org/2494333002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
(right):
> 
>
https://codereview.chromium.org/2494333002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp:97: return
> WTF::makeUnique<EmptyDataReader>(client);
> 
> Drop redundant WTF::. The same comment for other places in this CL.

done

[Gleb Lanbin, 2016-11-14 17:20:19]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 17:20:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 21:04:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 21:04:58]

Dry run: This issue passed the CQ dry run.

[Gleb Lanbin, 2016-11-14 21:08:22]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2016-11-14 21:08:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yutak@chromium.org
Link to the patchset: https://codereview.chromium.org/2494333002/#ps40001
(title: "Drop redundant WTF::")

[commit-bot: I haz the power, 2016-11-14 21:12:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 00:29:11]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-15 00:35:03]

Description was changed from

==========
Replace wrapUnique(new T(args)) by makeUnique<T>(args) in Blink

This is a follow-up on http://crrev.com/2455313003.
WTF::MakeUnique is based on base::MakeUnique and has the same interface as
std::make_unique

Before:
 std::unique_ptr<EightyColumnsFtw> eighty(new EightyColumnsFtw(100));
After:
 auto eighty = MakeUnique<EightyColumnsFtw>(100);

BUG=662304
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Replace wrapUnique(new T(args)) by makeUnique<T>(args) in Blink

This is a follow-up on http://crrev.com/2455313003.
WTF::MakeUnique is based on base::MakeUnique and has the same interface as
std::make_unique

Before:
 std::unique_ptr<EightyColumnsFtw> eighty(new EightyColumnsFtw(100));
After:
 auto eighty = MakeUnique<EightyColumnsFtw>(100);

BUG=662304
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/fd4636a8119d2b6a6f92b96011ff860b57963683
Cr-Commit-Position: refs/heads/master@{#432016}
==========

[commit-bot: I haz the power, 2016-11-15 00:35:06]

Patchset 2 (id:??) landed as
https://crrev.com/fd4636a8119d2b6a6f92b96011ff860b57963683
Cr-Commit-Position: refs/heads/master@{#432016}