third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp - Issue 2494333002: Replace wrapUnique(new T(args)) by makeUnique<T>(args) in Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp

Issue 2494333002: Replace wrapUnique(new T(args)) by makeUnique<T>(args) in Blink (Closed)

Patch Set: Drop redundant WTF:: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp ('k') | third_party/WebKit/Source/modules/vr/VRController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp

index ff708d87c05935b20701ced557e3d6cc9dadfd23..c1a680157ccb79eefcea81b8997bfeaf5d252325 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp

@@ -90,15 +90,14 @@ void ServiceWorkerLinkResource::process() {

document.addConsoleMessage(ConsoleMessage::create(

JSMessageSource, ErrorMessageLevel,

"Cannot register service worker with <link> element. " + message));

- wrapUnique(new RegistrationCallback(m_owner))

- ->onError(WebServiceWorkerError(

- WebServiceWorkerError::ErrorTypeSecurity, message));

+ makeUnique<RegistrationCallback>(m_owner)->onError(WebServiceWorkerError(

+ WebServiceWorkerError::ErrorTypeSecurity, message));

return;

}

container->registerServiceWorkerImpl(

&document, scriptURL, scopeURL,

- wrapUnique(new RegistrationCallback(m_owner)));

+ makeUnique<RegistrationCallback>(m_owner));

}

bool ServiceWorkerLinkResource::hasLoaded() const {