third_party/WebKit/Source/platform/threading/BackgroundTaskRunnerTest.cpp - Issue 2494333002: Replace wrapUnique(new T(args)) by makeUnique<T>(args) in Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/threading/BackgroundTaskRunnerTest.cpp

Issue 2494333002: Replace wrapUnique(new T(args)) by makeUnique<T>(args) in Blink (Closed)

Patch Set: Drop redundant WTF:: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/text/LocaleICU.cpp ('k') | third_party/WebKit/Source/platform/transforms/TransformationMatrix.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/threading/BackgroundTaskRunnerTest.cpp

diff --git a/third_party/WebKit/Source/platform/threading/BackgroundTaskRunnerTest.cpp b/third_party/WebKit/Source/platform/threading/BackgroundTaskRunnerTest.cpp

index e8c39359b44d30ee3ab60976a8d561c6207223ac..6717d30ae60e1c5b5ad61c178bbf19a075c9efc0 100644

--- a/third_party/WebKit/Source/platform/threading/BackgroundTaskRunnerTest.cpp

+++ b/third_party/WebKit/Source/platform/threading/BackgroundTaskRunnerTest.cpp

@@ -22,7 +22,7 @@ void PingPongTask(WaitableEvent* doneEvent) {

class BackgroundTaskRunnerTest : public testing::Test {};

TEST_F(BackgroundTaskRunnerTest, RunShortTaskOnBackgroundThread) {

- std::unique_ptr<WaitableEvent> doneEvent = wrapUnique(new WaitableEvent());

+ std::unique_ptr<WaitableEvent> doneEvent = makeUnique<WaitableEvent>();

BackgroundTaskRunner::postOnBackgroundThread(

BLINK_FROM_HERE,

crossThreadBind(&PingPongTask, crossThreadUnretained(doneEvent.get())),

@@ -32,7 +32,7 @@ TEST_F(BackgroundTaskRunnerTest, RunShortTaskOnBackgroundThread) {

}

TEST_F(BackgroundTaskRunnerTest, RunLongTaskOnBackgroundThread) {

- std::unique_ptr<WaitableEvent> doneEvent = wrapUnique(new WaitableEvent());

+ std::unique_ptr<WaitableEvent> doneEvent = makeUnique<WaitableEvent>();

BackgroundTaskRunner::postOnBackgroundThread(

BLINK_FROM_HERE,

crossThreadBind(&PingPongTask, crossThreadUnretained(doneEvent.get())),