third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp - Issue 2494333002: Replace wrapUnique(new T(args)) by makeUnique<T>(args) in Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

Issue 2494333002: Replace wrapUnique(new T(args)) by makeUnique<T>(args) in Blink (Closed)

Patch Set: Drop redundant WTF:: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp ('k') | third_party/WebKit/Source/platform/WebThreadSupportingGC.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

diff --git a/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp b/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

index ef62cdaf464fb6c96d3498349027016b9fc2372c..97e2f00ea43e84414dc24c8ee1944ec64697f701 100644

--- a/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

+++ b/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

@@ -436,7 +436,7 @@ void Bridge::send(const DOMArrayBuffer& binaryData,

DCHECK(m_peer);

// ArrayBuffer isn't thread-safe, hence the content of ArrayBuffer is copied

// into Vector<char>.

- std::unique_ptr<Vector<char>> data = wrapUnique(new Vector<char>(byteLength));

+ std::unique_ptr<Vector<char>> data = makeUnique<Vector<char>>(byteLength);

if (binaryData.byteLength())

memcpy(data->data(),

static_cast<const char*>(binaryData.data()) + byteOffset,