Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2488963005: Continue IFWL widget cleanup. (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Continue IFWL widget cleanup. Remove usunsed methods and FWL_Error returns. Committed: https://pdfium.googlesource.com/pdfium/+/c40697b24550182898b30de639790eaf82ebf158

Patch Set 1 #

Patch Set 2 : Rebase to master #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -379 lines) Patch
M xfa/fwl/core/cfwl_barcode.h View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_barcode.cpp View 1 chunk +1 line, -3 lines 2 comments Download
M xfa/fwl/core/cfwl_checkbox.h View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_checkbox.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_combobox.h View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_combobox.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M xfa/fwl/core/cfwl_datetimepicker.h View 1 chunk +16 lines, -30 lines 2 comments Download
M xfa/fwl/core/cfwl_datetimepicker.cpp View 2 chunks +18 lines, -87 lines 0 comments Download
M xfa/fwl/core/cfwl_listbox.h View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_listbox.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_picturebox.h View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_picturebox.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M xfa/fwl/core/cfwl_pushbutton.h View 1 chunk +1 line, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_pushbutton.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.h View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_dataprovider.h View 2 chunks +1 line, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimeedit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.h View 3 chunks +39 lines, -58 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.cpp View 16 chunks +43 lines, -154 lines 0 comments Download
M xfa/fwl/core/ifwl_monthcalendar.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_tooltip.h View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Issue 2486333004 Patch 20001

Dependent Patchsets:

Issue 2494743002 Patch 40001

Messages

Total messages: 9 (3 generated)
dsinclair
PTAL.
4 years, 1 month ago (2016-11-10 15:32:26 UTC) #2
Tom Sepez
https://codereview.chromium.org/2488963005/diff/20001/xfa/fwl/core/cfwl_barcode.cpp File xfa/fwl/core/cfwl_barcode.cpp (right): https://codereview.chromium.org/2488963005/diff/20001/xfa/fwl/core/cfwl_barcode.cpp#newcode114 xfa/fwl/core/cfwl_barcode.cpp:114: void CFWL_Barcode::GetCaption(IFWL_Widget* pWidget, CFX_WideString& wsCaption) { nit: can this ...
4 years, 1 month ago (2016-11-10 19:50:14 UTC) #3
dsinclair
https://codereview.chromium.org/2488963005/diff/20001/xfa/fwl/core/cfwl_barcode.cpp File xfa/fwl/core/cfwl_barcode.cpp (right): https://codereview.chromium.org/2488963005/diff/20001/xfa/fwl/core/cfwl_barcode.cpp#newcode114 xfa/fwl/core/cfwl_barcode.cpp:114: void CFWL_Barcode::GetCaption(IFWL_Widget* pWidget, CFX_WideString& wsCaption) { On 2016/11/10 19:50:14, ...
4 years, 1 month ago (2016-11-10 20:12:36 UTC) #4
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-11 18:21:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488963005/20001
4 years, 1 month ago (2016-11-12 00:21:02 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 00:36:23 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/c40697b24550182898b30de639790eaf82eb...

Powered by Google App Engine
This is Rietveld 408576698