Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2494743002: IFWL cleanup in the Combo classes (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

IFWL cleanup in the Combo classes Cleanup visibility and unused methods in the IFWL combo code. Committed: https://pdfium.googlesource.com/pdfium/+/27e66753c8bd6e664f26d05c1a468dc68be01913

Patch Set 1 #

Patch Set 2 : Return values #

Patch Set 3 : Rebase to master #

Total comments: 5

Patch Set 4 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -331 lines) Patch
M xfa/fwl/core/cfwl_combobox.h View 1 2 3 2 chunks +36 lines, -44 lines 0 comments Download
M xfa/fwl/core/cfwl_combobox.cpp View 1 2 3 5 chunks +20 lines, -96 lines 0 comments Download
M xfa/fwl/core/cfwl_listbox.h View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_listbox.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_combobox.h View 1 2 3 5 chunks +38 lines, -41 lines 0 comments Download
M xfa/fwl/core/ifwl_combobox.cpp View 1 2 3 29 chunks +46 lines, -117 lines 0 comments Download
M xfa/fwl/core/ifwl_comboboxproxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/core/ifwl_comboboxproxy.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_comboedit.h View 1 chunk +1 line, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_comboedit.cpp View 3 chunks +2 lines, -10 lines 0 comments Download
M xfa/fwl/core/ifwl_combolist.h View 1 chunk +7 lines, -6 lines 0 comments Download
M xfa/fwl/core/ifwl_listbox.h View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dsinclair
PTAL.
4 years, 1 month ago (2016-11-10 16:20:22 UTC) #2
npm
lgtm https://codereview.chromium.org/2494743002/diff/40001/xfa/fwl/core/cfwl_combobox.cpp File xfa/fwl/core/cfwl_combobox.cpp (right): https://codereview.chromium.org/2494743002/diff/40001/xfa/fwl/core/cfwl_combobox.cpp#newcode61 xfa/fwl/core/cfwl_combobox.cpp:61: void CFWL_ComboBox::GetTextByIndex(int32_t iIndex, CFX_WideString& wsText) { Can we ...
4 years, 1 month ago (2016-11-10 19:42:38 UTC) #3
Tom Sepez
lgtm https://codereview.chromium.org/2494743002/diff/40001/xfa/fwl/core/cfwl_combobox.h File xfa/fwl/core/cfwl_combobox.h (right): https://codereview.chromium.org/2494743002/diff/40001/xfa/fwl/core/cfwl_combobox.h#newcode74 xfa/fwl/core/cfwl_combobox.h:74: void GetTextByIndex(int32_t iIndex, CFX_WideString& wsText); nit: const method? ...
4 years, 1 month ago (2016-11-10 21:56:00 UTC) #4
dsinclair
https://codereview.chromium.org/2494743002/diff/40001/xfa/fwl/core/cfwl_combobox.h File xfa/fwl/core/cfwl_combobox.h (right): https://codereview.chromium.org/2494743002/diff/40001/xfa/fwl/core/cfwl_combobox.h#newcode74 xfa/fwl/core/cfwl_combobox.h:74: void GetTextByIndex(int32_t iIndex, CFX_WideString& wsText); On 2016/11/10 21:56:00, Tom ...
4 years, 1 month ago (2016-11-12 01:54:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494743002/60001
4 years, 1 month ago (2016-11-12 01:55:05 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 02:10:00 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/27e66753c8bd6e664f26d05c1a468dc68be0...

Powered by Google App Engine
This is Rietveld 408576698