Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1508)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2486333004: Remove IFWL methods proxied from CFWL classes (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove IFWL methods proxied from CFWL classes This CL removes a few methods from IFWL that are around just to proxy from CFWL methods which are, in turn, never called. Committed: https://pdfium.googlesource.com/pdfium/+/a0d3231037816d3f0e377e9c57a2bfaa1372e151

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase to master #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -128 lines) Patch
M xfa/fwl/core/cfwl_listbox.h View 2 chunks +18 lines, -24 lines 1 comment Download
M xfa/fwl/core/cfwl_listbox.cpp View 5 chunks +2 lines, -78 lines 1 comment Download
M xfa/fwl/core/cfwl_widget.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_widget.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/core/ifwl_widget.cpp View 1 chunk +0 lines, -13 lines 0 comments Download

Depends on Patchset:

Issue 2491103002 Patch 20001

Dependent Patchsets:

Issue 2488963005 Patch 20001

Messages

Total messages: 8 (3 generated)
dsinclair
PTAL. https://codereview.chromium.org/2486333004/diff/1/xfa/fwl/core/cfwl_listbox.cpp File xfa/fwl/core/cfwl_listbox.cpp (right): https://codereview.chromium.org/2486333004/diff/1/xfa/fwl/core/cfwl_listbox.cpp#newcode124 xfa/fwl/core/cfwl_listbox.cpp:124: wsCaption = L""; m_wsData was never set, made ...
4 years, 1 month ago (2016-11-10 14:44:55 UTC) #2
npm
https://codereview.chromium.org/2486333004/diff/20001/xfa/fwl/core/cfwl_listbox.cpp File xfa/fwl/core/cfwl_listbox.cpp (right): https://codereview.chromium.org/2486333004/diff/20001/xfa/fwl/core/cfwl_listbox.cpp#newcode205 xfa/fwl/core/cfwl_listbox.cpp:205: return 20; Isn't 0 better? https://codereview.chromium.org/2486333004/diff/20001/xfa/fwl/core/cfwl_listbox.h File xfa/fwl/core/cfwl_listbox.h (right): ...
4 years, 1 month ago (2016-11-10 19:12:07 UTC) #3
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-10 21:18:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486333004/20001
4 years, 1 month ago (2016-11-10 22:05:32 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 22:22:11 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/a0d3231037816d3f0e377e9c57a2bfaa1372...

Powered by Google App Engine
This is Rietveld 408576698