xfa/fwl/core/cfwl_listbox.cpp - Issue 2488963005: Continue IFWL widget cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/core/cfwl_listbox.cpp

Issue 2488963005: Continue IFWL widget cleanup. (Closed)

Patch Set: Rebase to master Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/core/cfwl_listbox.cpp

diff --git a/xfa/fwl/core/cfwl_listbox.cpp b/xfa/fwl/core/cfwl_listbox.cpp

index 9267f59e6f3bee55a434f84c5ac4a0a91b588340..5827ac4b26ddfb696dcfa898e80eb0176cf5fe9c 100644

--- a/xfa/fwl/core/cfwl_listbox.cpp

+++ b/xfa/fwl/core/cfwl_listbox.cpp

@@ -119,10 +119,8 @@ uint32_t CFWL_ListBox::GetItemStates(CFWL_ListItem* pItem) {

return pListItem->m_dwStates | pListItem->m_dwCheckState;

}

-FWL_Error CFWL_ListBox::GetCaption(IFWL_Widget* pWidget,

- CFX_WideString& wsCaption) {

+void CFWL_ListBox::GetCaption(IFWL_Widget* pWidget, CFX_WideString& wsCaption) {

wsCaption = L"";

- return FWL_Error::Succeeded;

}

int32_t CFWL_ListBox::CountItems(const IFWL_Widget* pWidget) {