xfa/fwl/core/cfwl_barcode.cpp - Issue 2488963005: Continue IFWL widget cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/core/cfwl_barcode.cpp

Issue 2488963005: Continue IFWL widget cleanup. (Closed)

Patch Set: Rebase to master Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/core/cfwl_barcode.cpp

diff --git a/xfa/fwl/core/cfwl_barcode.cpp b/xfa/fwl/core/cfwl_barcode.cpp

index 77faefed484d962d3be3ee270d9a6e33b94d4ded..053826d6b7ca1350b84eeeb8af38d04187705879 100644

--- a/xfa/fwl/core/cfwl_barcode.cpp

+++ b/xfa/fwl/core/cfwl_barcode.cpp

@@ -111,9 +111,7 @@ bool CFWL_Barcode::IsProtectedType() {

return GetWidget() ? ToBarcode(GetWidget())->IsProtectedType() : false;

}

-FWL_Error CFWL_Barcode::GetCaption(IFWL_Widget* pWidget,

- CFX_WideString& wsCaption) {

- return FWL_Error::Succeeded;

+void CFWL_Barcode::GetCaption(IFWL_Widget* pWidget, CFX_WideString& wsCaption) {

Tom Sepez 2016/11/10 19:50:14 nit: can this return the caption instead?

dsinclair 2016/11/10 20:12:35 Followup. Too much to keep track of in one go.

}

BC_CHAR_ENCODING CFWL_Barcode::GetCharEncoding() const {