Cleanup IFWL_Widget visibility and virtual parameters

Cleanup IFWL_Widget visibility and virtual parameters

This Cl cleans up the IFWL_Widget class including:

 * Making members and methods private where possible
 * Removing virtual methods that are never overridden
 * Removing methods that do nothing
 * Removing unchecked FWL_Error return codes

Committed: https://pdfium.googlesource.com/pdfium/+/98329fe75b9c3e5422344a37d787fb22c89c2ca2

[dsinclair, 2016-11-09 16:29:12]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 16:29:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-11-09 16:29:31]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-11-09 16:29:32]

PTAL.

https://codereview.chromium.org/2488953003/diff/1/xfa/fwl/core/cfwl_widgetpro...
File xfa/fwl/core/cfwl_widgetproperties.h (left):

https://codereview.chromium.org/2488953003/diff/1/xfa/fwl/core/cfwl_widgetpro...
xfa/fwl/core/cfwl_widgetproperties.h:24: CFX_Matrix m_ctmOnParent;
This is never set so is always the Identity.

[commit-bot: I haz the power, 2016-11-09 17:34:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 17:34:12]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-11-10 01:15:53]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org

[Tom Sepez, 2016-11-10 16:47:59]

lgtm

[dsinclair, 2016-11-10 17:20:58]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-11-10 17:21:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 17:40:21]

Description was changed from

==========
Cleanup IFWL_Widget visibility and virtual parameters

This Cl cleans up the IFWL_Widget class including:

 * Making members and methods private where possible
 * Removing virtual methods that are never overridden
 * Removing methods that do nothing
 * Removing unchecked FWL_Error return codes
==========

to

==========
Cleanup IFWL_Widget visibility and virtual parameters

This Cl cleans up the IFWL_Widget class including:

 * Making members and methods private where possible
 * Removing virtual methods that are never overridden
 * Removing methods that do nothing
 * Removing unchecked FWL_Error return codes

Committed:
https://pdfium.googlesource.com/pdfium/+/98329fe75b9c3e5422344a37d787fb22c89c...
==========

[commit-bot: I haz the power, 2016-11-10 17:40:22]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/98329fe75b9c3e5422344a37d787fb22c89c...