Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 2488953003: Cleanup IFWL_Widget visibility and virtual parameters (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleanup IFWL_Widget visibility and virtual parameters This Cl cleans up the IFWL_Widget class including: * Making members and methods private where possible * Removing virtual methods that are never overridden * Removing methods that do nothing * Removing unchecked FWL_Error return codes Committed: https://pdfium.googlesource.com/pdfium/+/98329fe75b9c3e5422344a37d787fb22c89c2ca2

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+433 lines, -637 lines) Patch
M xfa/fwl/core/cfwl_combobox.h View 3 chunks +3 lines, -4 lines 0 comments Download
M xfa/fwl/core/cfwl_combobox.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M xfa/fwl/core/cfwl_datetimepicker.h View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_datetimepicker.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fwl/core/cfwl_widget.h View 2 chunks +7 lines, -9 lines 0 comments Download
M xfa/fwl/core/cfwl_widget.cpp View 3 chunks +23 lines, -29 lines 0 comments Download
M xfa/fwl/core/cfwl_widgetproperties.h View 2 chunks +0 lines, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_barcode.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_barcode.cpp View 1 2 chunks +12 lines, -15 lines 0 comments Download
M xfa/fwl/core/ifwl_caret.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_caret.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M xfa/fwl/core/ifwl_checkbox.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_checkbox.cpp View 4 chunks +12 lines, -14 lines 0 comments Download
M xfa/fwl/core/ifwl_combobox.h View 4 chunks +14 lines, -15 lines 0 comments Download
M xfa/fwl/core/ifwl_combobox.cpp View 13 chunks +34 lines, -38 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.h View 3 chunks +10 lines, -11 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.cpp View 1 12 chunks +28 lines, -30 lines 0 comments Download
M xfa/fwl/core/ifwl_edit.h View 1 chunk +5 lines, -6 lines 0 comments Download
M xfa/fwl/core/ifwl_edit.cpp View 6 chunks +10 lines, -18 lines 0 comments Download
M xfa/fwl/core/ifwl_form.h View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fwl/core/ifwl_form.cpp View 7 chunks +10 lines, -16 lines 0 comments Download
M xfa/fwl/core/ifwl_formproxy.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fwl/core/ifwl_formproxy.cpp View 1 chunk +3 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_listbox.h View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fwl/core/ifwl_listbox.cpp View 5 chunks +10 lines, -15 lines 0 comments Download
M xfa/fwl/core/ifwl_monthcalendar.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_monthcalendar.cpp View 4 chunks +6 lines, -9 lines 0 comments Download
M xfa/fwl/core/ifwl_picturebox.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_picturebox.cpp View 3 chunks +8 lines, -11 lines 0 comments Download
M xfa/fwl/core/ifwl_pushbutton.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_pushbutton.cpp View 5 chunks +7 lines, -10 lines 0 comments Download
M xfa/fwl/core/ifwl_scrollbar.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_scrollbar.cpp View 3 chunks +8 lines, -11 lines 0 comments Download
M xfa/fwl/core/ifwl_spinbutton.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_spinbutton.cpp View 4 chunks +6 lines, -9 lines 0 comments Download
M xfa/fwl/core/ifwl_tooltip.h View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fwl/core/ifwl_tooltip.cpp View 5 chunks +12 lines, -18 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.h View 1 5 chunks +98 lines, -85 lines 0 comments Download
M xfa/fwl/core/ifwl_widget.cpp View 18 chunks +41 lines, -187 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
dsinclair
PTAL. https://codereview.chromium.org/2488953003/diff/1/xfa/fwl/core/cfwl_widgetproperties.h File xfa/fwl/core/cfwl_widgetproperties.h (left): https://codereview.chromium.org/2488953003/diff/1/xfa/fwl/core/cfwl_widgetproperties.h#oldcode24 xfa/fwl/core/cfwl_widgetproperties.h:24: CFX_Matrix m_ctmOnParent; This is never set so is ...
4 years, 1 month ago (2016-11-09 16:29:32 UTC) #4
dsinclair
4 years, 1 month ago (2016-11-10 01:15:54 UTC) #8
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-10 16:47:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488953003/20001
4 years, 1 month ago (2016-11-10 17:21:07 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 17:40:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/98329fe75b9c3e5422344a37d787fb22c89c...

Powered by Google App Engine
This is Rietveld 408576698