Cleanup IFWL_Widget visibility and virtual parameters

xfa/fwl/core/cfwl_combobox.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/core/cfwl_combobox.h"
 
 #include <utility>
 
@@ skipping 73 matching lines @@
 
 int32_t CFWL_ComboBox::GetCurSel() {
   return GetWidget() ? ToComboBox(GetWidget())->GetCurSel() : -1;
 }
 
 FWL_Error CFWL_ComboBox::SetCurSel(int32_t iSel) {
   return GetWidget() ? ToComboBox(GetWidget())->SetCurSel(iSel)
                      : FWL_Error::Indefinite;
 }
 
-FWL_Error CFWL_ComboBox::SetEditText(const CFX_WideString& wsText) {
-  return GetWidget() ? ToComboBox(GetWidget())->SetEditText(wsText)
-                     : FWL_Error::Indefinite;
+void CFWL_ComboBox::SetEditText(const CFX_WideString& wsText) {
+  if (GetWidget())
+    ToComboBox(GetWidget())->SetEditText(wsText);
 }
 
 int32_t CFWL_ComboBox::GetEditTextLength() const {
   return GetWidget() ? ToComboBox(GetWidget())->GetEditTextLength() : 0;
 }
 
 FWL_Error CFWL_ComboBox::GetEditText(CFX_WideString& wsText,
                                      int32_t nStart,
                                      int32_t nCount) const {
   return GetWidget()
@@ skipping 46 matching lines @@
   pItem->m_pData = pData;
   return FWL_Error::Succeeded;
 }
 
 void* CFWL_ComboBox::GetItemData(int32_t iIndex) {
   CFWL_ListItem* pItem =
       static_cast<CFWL_ListItem*>(GetItem(m_pIface.get(), iIndex));
   return pItem ? pItem->m_pData : nullptr;
 }
 
-FWL_Error CFWL_ComboBox::SetListTheme(IFWL_ThemeProvider* pTheme) {
-  return ToComboBox(GetWidget())->GetListBoxt()->SetThemeProvider(pTheme);
+void CFWL_ComboBox::SetListTheme(IFWL_ThemeProvider* pTheme) {
+  ToComboBox(GetWidget())->GetListBoxt()->SetThemeProvider(pTheme);
 }
 
 bool CFWL_ComboBox::AfterFocusShowDropList() {
   return ToComboBox(GetWidget())->AfterFocusShowDropList();
 }
 
 FWL_Error CFWL_ComboBox::OpenDropDownList(bool bActivate) {
   return ToComboBox(GetWidget())->OpenDropDownList(bActivate);
 }
 
@@ skipping 47 matching lines @@
 
 bool CFWL_ComboBox::EditDeSelect() {
   return GetWidget() ? ToComboBox(GetWidget())->EditDeSelect() : false;
 }
 
 FWL_Error CFWL_ComboBox::GetBBox(CFX_RectF& rect) {
   return GetWidget() ? ToComboBox(GetWidget())->GetBBox(rect)
                      : FWL_Error::Indefinite;
 }
 
-FWL_Error CFWL_ComboBox::EditModifyStylesEx(uint32_t dwStylesExAdded,
-                                            uint32_t dwStylesExRemoved) {
-  return GetWidget()
-             ? ToComboBox(GetWidget())
-                   ->EditModifyStylesEx(dwStylesExAdded, dwStylesExRemoved)
-             : FWL_Error::Indefinite;
+void CFWL_ComboBox::EditModifyStylesEx(uint32_t dwStylesExAdded,
+                                       uint32_t dwStylesExRemoved) {
+  if (GetWidget()) {
+    ToComboBox(GetWidget())
+        ->EditModifyStylesEx(dwStylesExAdded, dwStylesExRemoved);
+  }
 }
 
 FWL_Error CFWL_ComboBox::GetCaption(IFWL_Widget* pWidget,
                                     CFX_WideString& wsCaption) {
   return FWL_Error::Succeeded;
 }
 
 int32_t CFWL_ComboBox::CountItems(const IFWL_Widget* pWidget) {
   return m_ItemArray.size();
 }
@@ skipping 115 matching lines @@
 FWL_Error CFWL_ComboBox::SetItemCheckState(IFWL_Widget* pWidget,
                                            CFWL_ListItem* pItem,
                                            uint32_t dwCheckState) {
   static_cast<CFWL_ListItem*>(pItem)->m_dwCheckState = dwCheckState;
   return FWL_Error::Succeeded;
 }
 
 FX_FLOAT CFWL_ComboBox::GetListHeight(IFWL_Widget* pWidget) {
   return m_fMaxListHeight;
 }