Cleanup IFWL_Widget visibility and virtual parameters

xfa/fwl/core/ifwl_barcode.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/core/ifwl_barcode.h"
 
 #include "third_party/base/ptr_util.h"
 #include "xfa/fgas/font/fgas_gefont.h"
 #include "xfa/fwl/core/cfwl_themepart.h"
 #include "xfa/fwl/core/cfx_barcode.h"
 #include "xfa/fwl/core/fwl_noteimp.h"
 #include "xfa/fwl/core/ifwl_themeprovider.h"
 
 IFWL_Barcode::IFWL_Barcode(const IFWL_App* app,
                            std::unique_ptr<CFWL_WidgetProperties> properties)
     : IFWL_Edit(app, std::move(properties), nullptr),
       m_dwStatus(0),
       m_type(BC_UNKNOWN) {}
 
 IFWL_Barcode::~IFWL_Barcode() {}
 
 FWL_Type IFWL_Barcode::GetClassID() const {
   return FWL_Type::Barcode;
 }
 
-FWL_Error IFWL_Barcode::Update() {
+void IFWL_Barcode::Update() {
   if (IsLocked()) {
-    return FWL_Error::Indefinite;
+    return;
   }
-  FWL_Error ret = IFWL_Edit::Update();
+  IFWL_Edit::Update();
   GenerateBarcodeImageCache();
-  return ret;
 }
 
-FWL_Error IFWL_Barcode::DrawWidget(CFX_Graphics* pGraphics,
-                                   const CFX_Matrix* pMatrix) {
+void IFWL_Barcode::DrawWidget(CFX_Graphics* pGraphics,
+                              const CFX_Matrix* pMatrix) {
   if (!pGraphics)
-    return FWL_Error::Indefinite;
+    return;
   if (!m_pProperties->m_pThemeProvider)
-    return FWL_Error::Indefinite;
+    return;
   if ((m_pProperties->m_dwStates & FWL_WGTSTATE_Focused) == 0) {
     GenerateBarcodeImageCache();
     if (!m_pBarcodeEngine || (m_dwStatus & XFA_BCS_EncodeSuccess) == 0) {
-      return FWL_Error::Succeeded;
+      return;
     }
     CFX_Matrix mt;
     mt.e = m_rtClient.left;
     mt.f = m_rtClient.top;
     if (pMatrix) {
       mt.Concat(*pMatrix);
     }
     int32_t errorCode = 0;
-    if (!m_pBarcodeEngine->RenderDevice(pGraphics->GetRenderDevice(), pMatrix,
-                                        errorCode)) {
-      return FWL_Error::Indefinite;
-    }
-    return FWL_Error::Succeeded;
+    m_pBarcodeEngine->RenderDevice(pGraphics->GetRenderDevice(), pMatrix,
+                                   errorCode);
+    return;
   }
-  return IFWL_Edit::DrawWidget(pGraphics, pMatrix);
+  IFWL_Edit::DrawWidget(pGraphics, pMatrix);
 }
 void IFWL_Barcode::GenerateBarcodeImageCache() {
   if ((m_dwStatus & XFA_BCS_NeedUpdate) == 0)
     return;
   m_dwStatus = 0;
   CreateBarcodeEngine();
   IFWL_BarcodeDP* pData =
       static_cast<IFWL_BarcodeDP*>(m_pProperties->m_pDataProvider);
   if (!pData)
     return;
@@ skipping 103 matching lines @@
   return false;
 }
 
 void IFWL_Barcode::OnProcessEvent(CFWL_Event* pEvent) {
   if (pEvent->GetClassID() == CFWL_EventType::TextChanged) {
     m_pBarcodeEngine.reset();
     m_dwStatus = XFA_BCS_NeedUpdate;
   }
   IFWL_Edit::OnProcessEvent(pEvent);
 }