Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Unified Diff: xfa/fwl/core/cfwl_combobox.h

Issue 2488953003: Cleanup IFWL_Widget visibility and virtual parameters (Closed)
Patch Set: fixes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | xfa/fwl/core/cfwl_combobox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/cfwl_combobox.h
diff --git a/xfa/fwl/core/cfwl_combobox.h b/xfa/fwl/core/cfwl_combobox.h
index 4b544b45304aff2d835247067f66c9ac2111f945..e2d35d24b5cfa692706879d2683fb935825e731b 100644
--- a/xfa/fwl/core/cfwl_combobox.h
+++ b/xfa/fwl/core/cfwl_combobox.h
@@ -28,7 +28,7 @@ class CFWL_ComboBox : public CFWL_Widget, public IFWL_ComboBoxDP {
FWL_Error GetTextByIndex(int32_t iIndex, CFX_WideString& wsText);
int32_t GetCurSel();
FWL_Error SetCurSel(int32_t iSel);
- FWL_Error SetEditText(const CFX_WideString& wsText);
+ void SetEditText(const CFX_WideString& wsText);
int32_t GetEditTextLength() const;
FWL_Error GetEditText(CFX_WideString& wsText,
int32_t nStart = 0,
@@ -43,7 +43,7 @@ class CFWL_ComboBox : public CFWL_Widget, public IFWL_ComboBoxDP {
FWL_Error SetMaxListHeight(FX_FLOAT fMaxHeight);
FWL_Error SetItemData(int32_t iIndex, void* pData);
void* GetItemData(int32_t iIndex);
- FWL_Error SetListTheme(IFWL_ThemeProvider* pTheme);
+ void SetListTheme(IFWL_ThemeProvider* pTheme);
bool AfterFocusShowDropList();
FWL_Error OpenDropDownList(bool bActivate);
@@ -61,8 +61,7 @@ class CFWL_ComboBox : public CFWL_Widget, public IFWL_ComboBoxDP {
bool EditDelete();
bool EditDeSelect();
FWL_Error GetBBox(CFX_RectF& rect);
- FWL_Error EditModifyStylesEx(uint32_t dwStylesExAdded,
- uint32_t dwStylesExRemoved);
+ void EditModifyStylesEx(uint32_t dwStylesExAdded, uint32_t dwStylesExRemoved);
// IFWL_DataProvider
FWL_Error GetCaption(IFWL_Widget* pWidget,
« no previous file with comments | « no previous file | xfa/fwl/core/cfwl_combobox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698