Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2487943003: Rename IFWL_ListItem to CFWL_ListItem (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename IFWL_ListItem to CFWL_ListItem This CL removes the empty IFWL_ListItem class and uses CFWL_ListItem in its place. As well, the CFWL_ComboListItem is removed and replaced with CFWL_ListItem. These were almost duplicate classes and the one missing field added to CFWL_ListItem. Committed: https://pdfium.googlesource.com/pdfium/+/3ff4deea307c38462393e4f83dabe32949338168

Patch Set 1 #

Total comments: 1

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -255 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/fwl/core/cfwl_combobox.h View 2 chunks +16 lines, -30 lines 0 comments Download
M xfa/fwl/core/cfwl_combobox.cpp View 1 8 chunks +38 lines, -42 lines 0 comments Download
M xfa/fwl/core/cfwl_listbox.h View 3 chunks +30 lines, -44 lines 0 comments Download
M xfa/fwl/core/cfwl_listbox.cpp View 20 chunks +31 lines, -43 lines 0 comments Download
A xfa/fwl/core/cfwl_listitem.h View 1 chunk +30 lines, -0 lines 0 comments Download
A xfa/fwl/core/cfwl_listitem.cpp View 1 1 chunk +19 lines, -0 lines 0 comments Download
M xfa/fwl/core/ifwl_combobox.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M xfa/fwl/core/ifwl_combolist.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M xfa/fwl/core/ifwl_listbox.h View 6 chunks +35 lines, -36 lines 0 comments Download
M xfa/fwl/core/ifwl_listbox.cpp View 30 chunks +38 lines, -38 lines 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL. https://codereview.chromium.org/2487943003/diff/1/xfa/fwl/core/cfwl_combobox.h File xfa/fwl/core/cfwl_combobox.h (left): https://codereview.chromium.org/2487943003/diff/1/xfa/fwl/core/cfwl_combobox.h#oldcode21 xfa/fwl/core/cfwl_combobox.h:21: CFX_RectF m_rtItem; These were shadowed before, hopefully there ...
4 years, 1 month ago (2016-11-09 14:28:16 UTC) #4
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-09 17:31:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487943003/20001
4 years, 1 month ago (2016-11-09 18:08:48 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 18:09:08 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/3ff4deea307c38462393e4f83dabe3294933...

Powered by Google App Engine
This is Rietveld 408576698