Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2485933003: Fixes an invalidated pointer access in NTPSnipppetsFetcher. (Closed)

Created:
4 years, 1 month ago by tschumann
Modified:
4 years, 1 month ago
Reviewers:
Marc Treib
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes an invalidated pointer access in NTPSnipppetsFetcher. Also fixes other post-commit comments by treib. BUG=634892 Committed: https://crrev.com/8dd24f9480cbfbd950827c6fcf0b8cdc1eab60a8 Cr-Commit-Position: refs/heads/master@{#430656}

Patch Set 1 #

Patch Set 2 : adressed other comments from https://codereview.chromium.org/2473483006/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -26 lines) Patch
M chrome/browser/ntp_snippets/download_suggestions_provider.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ntp_snippets/download_suggestions_provider.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/content_suggestions_provider.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/content_suggestions_service.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/ntp_snippets/content_suggestions_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/remote/ntp_snippets_fetcher.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M components/ntp_snippets/remote/ntp_snippets_fetcher_unittest.cc View 3 chunks +18 lines, -3 lines 0 comments Download
M components/ntp_snippets/remote/ntp_snippets_service.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M components/ntp_snippets/remote/ntp_snippets_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
tschumann
4 years, 1 month ago (2016-11-08 16:58:02 UTC) #3
Marc Treib
LGTM, thanks!
4 years, 1 month ago (2016-11-08 17:23:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485933003/20001
4 years, 1 month ago (2016-11-08 18:14:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 18:20:47 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 18:38:39 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8dd24f9480cbfbd950827c6fcf0b8cdc1eab60a8
Cr-Commit-Position: refs/heads/master@{#430656}

Powered by Google App Engine
This is Rietveld 408576698