Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h

Issue 2485933003: Fixes an invalidated pointer access in NTPSnipppetsFetcher. (Closed)
Patch Set: adressed other comments from https://codereview.chromium.org/2473483006/ Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_NTP_SNIPPETS_BOOKMARKS_BOOKMARK_SUGGESTIONS_PROVIDER_H_ 5 #ifndef COMPONENTS_NTP_SNIPPETS_BOOKMARKS_BOOKMARK_SUGGESTIONS_PROVIDER_H_
6 #define COMPONENTS_NTP_SNIPPETS_BOOKMARKS_BOOKMARK_SUGGESTIONS_PROVIDER_H_ 6 #define COMPONENTS_NTP_SNIPPETS_BOOKMARKS_BOOKMARK_SUGGESTIONS_PROVIDER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
(...skipping 26 matching lines...) Expand all
37 37
38 private: 38 private:
39 // ContentSuggestionsProvider implementation. 39 // ContentSuggestionsProvider implementation.
40 CategoryStatus GetCategoryStatus(Category category) override; 40 CategoryStatus GetCategoryStatus(Category category) override;
41 CategoryInfo GetCategoryInfo(Category category) override; 41 CategoryInfo GetCategoryInfo(Category category) override;
42 void DismissSuggestion(const ContentSuggestion::ID& suggestion_id) override; 42 void DismissSuggestion(const ContentSuggestion::ID& suggestion_id) override;
43 void FetchSuggestionImage(const ContentSuggestion::ID& suggestion_id, 43 void FetchSuggestionImage(const ContentSuggestion::ID& suggestion_id,
44 const ImageFetchedCallback& callback) override; 44 const ImageFetchedCallback& callback) override;
45 void Fetch(const Category& category, 45 void Fetch(const Category& category,
46 const std::set<std::string>& known_suggestion_ids, 46 const std::set<std::string>& known_suggestion_ids,
47 FetchingCallback callback) override; 47 const FetchingCallback& callback) override;
48 void ClearHistory( 48 void ClearHistory(
49 base::Time begin, 49 base::Time begin,
50 base::Time end, 50 base::Time end,
51 const base::Callback<bool(const GURL& url)>& filter) override; 51 const base::Callback<bool(const GURL& url)>& filter) override;
52 void ClearCachedSuggestions(Category category) override; 52 void ClearCachedSuggestions(Category category) override;
53 void GetDismissedSuggestionsForDebugging( 53 void GetDismissedSuggestionsForDebugging(
54 Category category, 54 Category category,
55 const DismissedSuggestionsCallback& callback) override; 55 const DismissedSuggestionsCallback& callback) override;
56 void ClearDismissedSuggestionsForDebugging(Category category) override; 56 void ClearDismissedSuggestionsForDebugging(Category category) override;
57 57
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 // For six weeks after first installing M54, this is true and the 116 // For six weeks after first installing M54, this is true and the
117 // fallback implemented in BookmarkLastVisitUtils is activated. 117 // fallback implemented in BookmarkLastVisitUtils is activated.
118 bool creation_date_fallback_; 118 bool creation_date_fallback_;
119 119
120 DISALLOW_COPY_AND_ASSIGN(BookmarkSuggestionsProvider); 120 DISALLOW_COPY_AND_ASSIGN(BookmarkSuggestionsProvider);
121 }; 121 };
122 122
123 } // namespace ntp_snippets 123 } // namespace ntp_snippets
124 124
125 #endif // COMPONENTS_NTP_SNIPPETS_BOOKMARKS_BOOKMARK_SUGGESTIONS_PROVIDER_H_ 125 #endif // COMPONENTS_NTP_SNIPPETS_BOOKMARKS_BOOKMARK_SUGGESTIONS_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698