components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h - Issue 2485933003: Fixes an invalidated pointer access in NTPSnipppetsFetcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

Issue 2485933003: Fixes an invalidated pointer access in NTPSnipppetsFetcher. (Closed)

Patch Set: adressed other comments from https://codereview.chromium.org/2473483006/ Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc ('k') | components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

index 8b3b08d70cb208da86feabbbef077b07e0cd47c0..a821d90f48f3bf1df9d94b41038f453840995d8f 100644

--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

@@ -51,7 +51,7 @@ class PhysicalWebPageSuggestionsProvider : public ContentSuggestionsProvider {

const ImageFetchedCallback& callback) override;

void Fetch(const Category& category,

const std::set<std::string>& known_suggestion_ids,

- FetchingCallback callback) override;

+ const FetchingCallback& callback) override;

void ClearHistory(

base::Time begin,

base::Time end,