Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Side by Side Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

Issue 2485933003: Fixes an invalidated pointer access in NTPSnipppetsFetcher. (Closed)
Patch Set: adressed other comments from https://codereview.chromium.org/2473483006/ Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_NTP_SNIPPETS_PHYSICAL_WEB_PAGES_PHYSICAL_WEB_PAGE_SUGGESTIONS _PROVIDER_H_ 5 #ifndef COMPONENTS_NTP_SNIPPETS_PHYSICAL_WEB_PAGES_PHYSICAL_WEB_PAGE_SUGGESTIONS _PROVIDER_H_
6 #define COMPONENTS_NTP_SNIPPETS_PHYSICAL_WEB_PAGES_PHYSICAL_WEB_PAGE_SUGGESTIONS _PROVIDER_H_ 6 #define COMPONENTS_NTP_SNIPPETS_PHYSICAL_WEB_PAGES_PHYSICAL_WEB_PAGE_SUGGESTIONS _PROVIDER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 void OnDisplayableUrlsChanged(const std::vector<UrlInfo>& urls); 44 void OnDisplayableUrlsChanged(const std::vector<UrlInfo>& urls);
45 45
46 // ContentSuggestionsProvider implementation. 46 // ContentSuggestionsProvider implementation.
47 CategoryStatus GetCategoryStatus(Category category) override; 47 CategoryStatus GetCategoryStatus(Category category) override;
48 CategoryInfo GetCategoryInfo(Category category) override; 48 CategoryInfo GetCategoryInfo(Category category) override;
49 void DismissSuggestion(const ContentSuggestion::ID& suggestion_id) override; 49 void DismissSuggestion(const ContentSuggestion::ID& suggestion_id) override;
50 void FetchSuggestionImage(const ContentSuggestion::ID& suggestion_id, 50 void FetchSuggestionImage(const ContentSuggestion::ID& suggestion_id,
51 const ImageFetchedCallback& callback) override; 51 const ImageFetchedCallback& callback) override;
52 void Fetch(const Category& category, 52 void Fetch(const Category& category,
53 const std::set<std::string>& known_suggestion_ids, 53 const std::set<std::string>& known_suggestion_ids,
54 FetchingCallback callback) override; 54 const FetchingCallback& callback) override;
55 void ClearHistory( 55 void ClearHistory(
56 base::Time begin, 56 base::Time begin,
57 base::Time end, 57 base::Time end,
58 const base::Callback<bool(const GURL& url)>& filter) override; 58 const base::Callback<bool(const GURL& url)>& filter) override;
59 void ClearCachedSuggestions(Category category) override; 59 void ClearCachedSuggestions(Category category) override;
60 void GetDismissedSuggestionsForDebugging( 60 void GetDismissedSuggestionsForDebugging(
61 Category category, 61 Category category,
62 const DismissedSuggestionsCallback& callback) override; 62 const DismissedSuggestionsCallback& callback) override;
63 void ClearDismissedSuggestionsForDebugging(Category category) override; 63 void ClearDismissedSuggestionsForDebugging(Category category) override;
64 64
65 private: 65 private:
66 void NotifyStatusChanged(CategoryStatus new_status); 66 void NotifyStatusChanged(CategoryStatus new_status);
67 67
68 CategoryStatus category_status_; 68 CategoryStatus category_status_;
69 const Category provided_category_; 69 const Category provided_category_;
70 70
71 DISALLOW_COPY_AND_ASSIGN(PhysicalWebPageSuggestionsProvider); 71 DISALLOW_COPY_AND_ASSIGN(PhysicalWebPageSuggestionsProvider);
72 }; 72 };
73 73
74 } // namespace ntp_snippets 74 } // namespace ntp_snippets
75 75
76 #endif // COMPONENTS_NTP_SNIPPETS_PHYSICAL_WEB_PAGES_PHYSICAL_WEB_PAGE_SUGGESTI ONS_PROVIDER_H_ 76 #endif // COMPONENTS_NTP_SNIPPETS_PHYSICAL_WEB_PAGES_PHYSICAL_WEB_PAGE_SUGGESTI ONS_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698