Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: components/ntp_snippets/content_suggestions_provider.h

Issue 2485933003: Fixes an invalidated pointer access in NTPSnipppetsFetcher. (Closed)
Patch Set: adressed other comments from https://codereview.chromium.org/2473483006/ Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/content_suggestions_provider.h
diff --git a/components/ntp_snippets/content_suggestions_provider.h b/components/ntp_snippets/content_suggestions_provider.h
index 0dc7634ef077b50b2a7d4cfd6f1b22ad1ed34acd..00166db78a618e17c4d311b6c3f251c5d8d76e85 100644
--- a/components/ntp_snippets/content_suggestions_provider.h
+++ b/components/ntp_snippets/content_suggestions_provider.h
@@ -109,7 +109,7 @@ class ContentSuggestionsProvider {
// existing suggestions.
virtual void Fetch(const Category& category,
const std::set<std::string>& known_suggestion_ids,
- FetchingCallback callback) = 0;
+ const FetchingCallback& callback) = 0;
// Removes history from the specified time range where the URL matches the
// |filter|. The data removed depends on the provider. Note that the

Powered by Google App Engine
This is Rietveld 408576698