Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2478463002: Reland of place for loops with |arraysize| with for each loops (Closed)

Created:
4 years, 1 month ago by jdoerrie
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, darin-cc_chromium.org, tfarina, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of place for loops with |arraysize| with for each loops (patchset #1 id:1 of https://codereview.chromium.org/2424793002/ ) Reason for revert: Relanding, because the flaky unittest was fixed: http://crbug.com/656926 Original issue's description: > Revert of Replace for loops with |arraysize| with for each loops (patchset #2 id:20001 of https://codereview.chromium.org/2417783004/ ) > > Reason for revert: > Speculative revert from sheriff. Suspect that the CL breaks components_unittests on Mac. > > https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/31721/steps/components_unittests%20on%20Mac-10.9 > > Not sure. Will revert the revert if it does not help. > > Original issue's description: > > Replace for loops with |arraysize| with for each loops > > > > This change replaces for-loops involving a loop variable and the > > |arraysize| macro with a C++11 for-each-loop where appropriate. > > > > A few usages of |arraysize| in a for-loop remain, in these the loop > > variable is used as well. This can be simply logging the iteration > > number or indexing another array of the same size. > > > > BUG=655950 > > > > Committed: https://crrev.com/54e466c9fd2ff04136f8f305615910e8f9085642 > > Cr-Commit-Position: refs/heads/master@{#425651} > > TBR=vabr@chromium.org,jdoerrie@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=655950 > > Committed: https://crrev.com/e00a337f9c62d1d32c315ecacc63cec380a36e27 > Cr-Commit-Position: refs/heads/master@{#425660} TBR=vabr@chromium.org,henrika@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=655950 Committed: https://crrev.com/188854d02b406012ec48a550ffcdd273c8b14d53 Cr-Commit-Position: refs/heads/master@{#429578}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -229 lines) Patch
M components/autofill/content/renderer/form_cache.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/autofill/core/browser/address_i18n_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M components/autofill/core/browser/address_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M components/autofill/core/browser/autofill_data_util.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M components/autofill/core/browser/autofill_ie_toolbar_import_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 4 chunks +16 lines, -15 lines 0 comments Download
M components/autofill/core/browser/autofill_merge_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/contact_info_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/autofill/core/browser/credit_card.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/autofill/core/browser/credit_card_unittest.cc View 6 chunks +42 lines, -49 lines 0 comments Download
M components/autofill/core/browser/phone_field_unittest.cc View 6 chunks +24 lines, -24 lines 0 comments Download
M components/autofill/core/browser/phone_number_i18n_unittest.cc View 1 chunk +11 lines, -14 lines 0 comments Download
M components/autofill/core/browser/state_names.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M components/autofill/core/browser/ui/card_unmask_prompt_controller_impl_unittest.cc View 3 chunks +16 lines, -17 lines 0 comments Download
M components/autofill/core/browser/validation_unittest.cc View 2 chunks +20 lines, -25 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table_unittest.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M components/autofill/core/common/autofill_regexes_unittest.cc View 6 chunks +6 lines, -12 lines 0 comments Download
M components/autofill/core/common/autofill_util_unittest.cc View 3 chunks +21 lines, -22 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jdoerrie
Created Reland of place for loops with |arraysize| with for each loops
4 years, 1 month ago (2016-11-03 13:47:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478463002/1
4 years, 1 month ago (2016-11-03 13:48:10 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-03 13:48:12 UTC) #5
vabr (Chromium)
LGTM, as confirmed with jdoerrie, this is a no-change reland of the initial CL. The ...
4 years, 1 month ago (2016-11-03 14:02:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478463002/1
4 years, 1 month ago (2016-11-03 14:03:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 14:42:23 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 14:44:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/188854d02b406012ec48a550ffcdd273c8b14d53
Cr-Commit-Position: refs/heads/master@{#429578}

Powered by Google App Engine
This is Rietveld 408576698