DescriptionReland of place for loops with |arraysize| with for each loops (patchset #1 id:1 of https://codereview.chromium.org/2424793002/ )
Reason for revert:
Relanding, because the flaky unittest was fixed: http://crbug.com/656926
Original issue's description:
> Revert of Replace for loops with |arraysize| with for each loops (patchset #2 id:20001 of https://codereview.chromium.org/2417783004/ )
>
> Reason for revert:
> Speculative revert from sheriff. Suspect that the CL breaks components_unittests on Mac.
>
> https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/31721/steps/components_unittests%20on%20Mac-10.9
>
> Not sure. Will revert the revert if it does not help.
>
> Original issue's description:
> > Replace for loops with |arraysize| with for each loops
> >
> > This change replaces for-loops involving a loop variable and the
> > |arraysize| macro with a C++11 for-each-loop where appropriate.
> >
> > A few usages of |arraysize| in a for-loop remain, in these the loop
> > variable is used as well. This can be simply logging the iteration
> > number or indexing another array of the same size.
> >
> > BUG=655950
> >
> > Committed: https://crrev.com/54e466c9fd2ff04136f8f305615910e8f9085642
> > Cr-Commit-Position: refs/heads/master@{#425651}
>
> TBR=vabr@chromium.org,jdoerrie@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=655950
>
> Committed: https://crrev.com/e00a337f9c62d1d32c315ecacc63cec380a36e27
> Cr-Commit-Position: refs/heads/master@{#425660}
TBR=vabr@chromium.org,henrika@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=655950
Committed: https://crrev.com/188854d02b406012ec48a550ffcdd273c8b14d53
Cr-Commit-Position: refs/heads/master@{#429578}
Patch Set 1 #Messages
Total messages: 11 (4 generated)
|