Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: components/autofill/core/browser/address_i18n_unittest.cc

Issue 2478463002: Reland of place for loops with |arraysize| with for each loops (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/address_i18n_unittest.cc
diff --git a/components/autofill/core/browser/address_i18n_unittest.cc b/components/autofill/core/browser/address_i18n_unittest.cc
index c36223d1de554888a692c5e8182610d40c5561f8..59ddc2137a3585f4bf6f6ad1a8d35c31fa7d4b28 100644
--- a/components/autofill/core/browser/address_i18n_unittest.cc
+++ b/components/autofill/core/browser/address_i18n_unittest.cc
@@ -61,14 +61,14 @@
{false, NAME_FULL, RECIPIENT},
};
- for (size_t i = 0; i < arraysize(kTestData); ++i) {
+ for (const auto& test_data : kTestData) {
AddressField address_field;
- EXPECT_TRUE(FieldForType(kTestData[i].server_field, &address_field));
- EXPECT_EQ(kTestData[i].address_field, address_field);
+ EXPECT_TRUE(FieldForType(test_data.server_field, &address_field));
+ EXPECT_EQ(test_data.address_field, address_field);
ServerFieldType server_field =
- TypeForField(kTestData[i].address_field, kTestData[i].billing);
- EXPECT_EQ(kTestData[i].server_field, server_field);
+ TypeForField(test_data.address_field, test_data.billing);
+ EXPECT_EQ(test_data.server_field, server_field);
}
}
@@ -83,10 +83,10 @@
{ADDRESS_HOME_LINE2, STREET_ADDRESS},
};
- for (size_t i = 0; i < arraysize(kTestData); ++i) {
+ for (const auto& test_data : kTestData) {
AddressField actual_address_field;
- FieldForType(kTestData[i].server_field, &actual_address_field);
- EXPECT_EQ(kTestData[i].expected_address_field, actual_address_field);
+ FieldForType(test_data.server_field, &actual_address_field);
+ EXPECT_EQ(test_data.expected_address_field, actual_address_field);
}
}
« no previous file with comments | « components/autofill/content/renderer/form_cache.cc ('k') | components/autofill/core/browser/address_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698