Reland of place for loops with |arraysize| with for each loops

components/autofill/core/browser/webdata/autofill_table_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <map>
 #include <set>
 #include <string>
 #include <tuple>
@@ skipping 1978 matching lines @@
       {{"user@test", "test_user"}, "user@t", 1, {"user@test", nullptr}},
       {{"user.test", "test_user"}, "er.tes", 0, {nullptr,     nullptr}},
       {{"user test", "test_user"}, "_ser",   0, {nullptr,     nullptr}},
       {{"user.test", "test_user"}, "%ser",   0, {nullptr,     nullptr}},
       {{"user.test", "test_user"},
        "; DROP TABLE autofill;",
        0,
        {nullptr, nullptr}},
   };
 
-  for (size_t i = 0; i < arraysize(kTestCases); ++i) {
+  for (const auto& test_case : kTestCases) {
     SCOPED_TRACE(testing::Message()
-                 << "suggestion = " << kTestCases[i].field_suggestion[0]
-                 << ", contents = " << kTestCases[i].field_contents);
+                 << "suggestion = " << test_case.field_suggestion[0]
+                 << ", contents = " << test_case.field_contents);
 
     Time t1 = Time::Now();
 
     // Simulate the submission of a handful of entries in a field called "Name".
     AutofillChangeList changes;
     FormFieldData field;
     for (size_t k = 0; k < kMaxCount; ++k) {
       field.name = ASCIIToUTF16("Name");
-      field.value = ASCIIToUTF16(kTestCases[i].field_suggestion[k]);
+      field.value = ASCIIToUTF16(test_case.field_suggestion[k]);
       table_->AddFormFieldValue(field, &changes);
     }
 
     std::vector<base::string16> v;
     table_->GetFormValuesForElementName(
-        ASCIIToUTF16("Name"), ASCIIToUTF16(kTestCases[i].field_contents), &v,
-        6);
+        ASCIIToUTF16("Name"), ASCIIToUTF16(test_case.field_contents), &v, 6);
 
-    EXPECT_EQ(kTestCases[i].expected_suggestion_count, v.size());
-    for (size_t j = 0; j < kTestCases[i].expected_suggestion_count; ++j) {
-      EXPECT_EQ(ASCIIToUTF16(kTestCases[i].expected_suggestion[j]), v[j]);
+    EXPECT_EQ(test_case.expected_suggestion_count, v.size());
+    for (size_t j = 0; j < test_case.expected_suggestion_count; ++j) {
+      EXPECT_EQ(ASCIIToUTF16(test_case.expected_suggestion[j]), v[j]);
     }
 
     changes.clear();
     table_->RemoveFormElementsAddedBetween(t1, Time(), &changes);
   }
 }
 
 }  // namespace autofill