Reland of place for loops with |arraysize| with for each loops

components/autofill/core/browser/address_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <string>
 
 #include "base/macros.h"
 #include "base/strings/string16.h"
@@ skipping 114 matching lines @@
   Address address;
   address.SetRawInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("US"));
 
   const char* const kValidMatches[] = {
     "United States",
     "USA",
     "US",
     "United states",
     "us"
   };
-  for (size_t i = 0; i < arraysize(kValidMatches); ++i) {
-    SCOPED_TRACE(kValidMatches[i]);
+  for (const char* valid_match : kValidMatches) {
+    SCOPED_TRACE(valid_match);
     ServerFieldTypeSet matching_types;
-    address.GetMatchingTypes(ASCIIToUTF16(kValidMatches[i]), "US",
-                             &matching_types);
+    address.GetMatchingTypes(ASCIIToUTF16(valid_match), "US", &matching_types);
     ASSERT_EQ(1U, matching_types.size());
     EXPECT_EQ(ADDRESS_HOME_COUNTRY, *matching_types.begin());
   }
 
   const char* const kInvalidMatches[] = {
     "United",
     "Garbage"
   };
-  for (size_t i = 0; i < arraysize(kInvalidMatches); ++i) {
+  for (const char* invalid_match : kInvalidMatches) {
     ServerFieldTypeSet matching_types;
-    address.GetMatchingTypes(ASCIIToUTF16(kInvalidMatches[i]), "US",
+    address.GetMatchingTypes(ASCIIToUTF16(invalid_match), "US",
                              &matching_types);
     EXPECT_EQ(0U, matching_types.size());
   }
 
   // Make sure that garbage values don't match when the country code is empty.
   address.SetRawInfo(ADDRESS_HOME_COUNTRY, base::string16());
   EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_COUNTRY));
   ServerFieldTypeSet matching_types;
   address.GetMatchingTypes(ASCIIToUTF16("Garbage"), "US", &matching_types);
   EXPECT_EQ(0U, matching_types.size());
@@ skipping 217 matching lines @@
                                ASCIIToUTF16("Address line 1"
                                             "Address line 2"
                                             "\n"),
                                "en-US"));
   EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_LINE1));
   EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_LINE2));
   EXPECT_EQ(base::string16(), address.GetRawInfo(ADDRESS_HOME_STREET_ADDRESS));
 }
 
 }  // namespace autofill