Reland of place for loops with |arraysize| with for each loops

components/autofill/core/browser/address_i18n_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/address_i18n.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
@@ skipping 43 matching lines @@
     {false, ADDRESS_HOME_STATE, ADMIN_AREA},
     {false, ADDRESS_HOME_CITY, LOCALITY},
     {false, ADDRESS_HOME_DEPENDENT_LOCALITY, DEPENDENT_LOCALITY},
     {false, ADDRESS_HOME_SORTING_CODE, SORTING_CODE},
     {false, ADDRESS_HOME_ZIP, POSTAL_CODE},
     {false, ADDRESS_HOME_STREET_ADDRESS, STREET_ADDRESS},
     {false, COMPANY_NAME, ORGANIZATION},
     {false, NAME_FULL, RECIPIENT},
   };
 
-  for (size_t i = 0; i < arraysize(kTestData); ++i) {
+  for (const auto& test_data : kTestData) {
     AddressField address_field;
-    EXPECT_TRUE(FieldForType(kTestData[i].server_field, &address_field));
-    EXPECT_EQ(kTestData[i].address_field, address_field);
+    EXPECT_TRUE(FieldForType(test_data.server_field, &address_field));
+    EXPECT_EQ(test_data.address_field, address_field);
 
     ServerFieldType server_field =
-        TypeForField(kTestData[i].address_field, kTestData[i].billing);
-    EXPECT_EQ(kTestData[i].server_field, server_field);
+        TypeForField(test_data.address_field, test_data.billing);
+    EXPECT_EQ(test_data.server_field, server_field);
   }
 }
 
 TEST(AddressI18nTest, FieldTypeUnidirectionalConversions) {
   static const struct {
     ServerFieldType server_field;
     AddressField expected_address_field;
   } kTestData[] = {
     {ADDRESS_BILLING_LINE1, STREET_ADDRESS},
     {ADDRESS_BILLING_LINE2, STREET_ADDRESS},
     {ADDRESS_HOME_LINE1, STREET_ADDRESS},
     {ADDRESS_HOME_LINE2, STREET_ADDRESS},
   };
 
-  for (size_t i = 0; i < arraysize(kTestData); ++i) {
+  for (const auto& test_data : kTestData) {
     AddressField actual_address_field;
-    FieldForType(kTestData[i].server_field, &actual_address_field);
-    EXPECT_EQ(kTestData[i].expected_address_field, actual_address_field);
+    FieldForType(test_data.server_field, &actual_address_field);
+    EXPECT_EQ(test_data.expected_address_field, actual_address_field);
   }
 }
 
 TEST(AddressI18nTest, UnconvertableServerFields) {
   EXPECT_FALSE(FieldForType(PHONE_HOME_NUMBER, NULL));
   EXPECT_FALSE(FieldForType(EMAIL_ADDRESS, NULL));
 }
 
 TEST(AddressI18nTest, CreateAddressDataFromAutofillProfile) {
   AutofillProfile profile(base::GenerateGUID(), "http://www.example.com/");
@@ skipping 22 matching lines @@
   expected.postal_code = "91111";
   expected.language_code = "en";
   expected.organization = "Underworld";
   expected.recipient = "John H. Doe";
 
   EXPECT_EQ(expected, *actual);
 }
 
 }  // namespace i18n
 }  // namespace autofill