logicalHeightWithVisibleOverflow() needs to include overhanging floats.

logicalHeightWithVisibleOverflow() needs to include overhanging floats.

Otherwise we might end up skipping layout of blocks that contain floats
that really need to be relaid out.

We get some marking for layout for free in layoutBlockFlow(), if
pageLogicalHeightChanged, but that only goes one level deep.

Committed: https://crrev.com/22c5e1a6ac7251d197f48b4b6f17e4e6ef2f741c
Cr-Commit-Position: refs/heads/master@{#429611}

[mstensho (USE GERRIT), 2016-11-03 09:33:01]

The CQ bit was checked by mstensho@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 09:33:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mstensho (USE GERRIT), 2016-11-03 10:14:29]

Description was changed from

==========
logicalHeightWithVisibleOverflow() needs to include overhanging floats.

Otherwise we might end up skipping layout of blocks that contain floats
that really need to be relaid out.
==========

to

==========
logicalHeightWithVisibleOverflow() needs to include overhanging floats.

Otherwise we might end up skipping layout of blocks that contain floats
that really need to be relaid out.

We get some marking for layout for free in layoutBlockFlow(), if
pageLogicalHeightChanged, but that only goes one level deep.
==========

[commit-bot: I haz the power, 2016-11-03 11:33:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 11:33:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[mstensho (USE GERRIT), 2016-11-03 11:41:33]

mstensho@opera.com changed reviewers:
+ eae@chromium.org, szager@chromium.org

[mstensho (USE GERRIT), 2016-11-03 11:41:33]

Before I can refactor layoutBlockFlow() in
https://codereview.chromium.org/2471623003/ , I'd like to clean up some
pagination stuff there. In particular, I'd like to get rid of relayoutChildren
being set if pageLogicalHeightChanged. Currently, when removing that, some tests
start to fail. Here's one of the fixes required.

[eae, 2016-11-03 16:15:19]

LGTM

[eae, 2016-11-03 16:15:24]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-11-03 16:16:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 16:21:12]

Description was changed from

==========
logicalHeightWithVisibleOverflow() needs to include overhanging floats.

Otherwise we might end up skipping layout of blocks that contain floats
that really need to be relaid out.

We get some marking for layout for free in layoutBlockFlow(), if
pageLogicalHeightChanged, but that only goes one level deep.
==========

to

==========
logicalHeightWithVisibleOverflow() needs to include overhanging floats.

Otherwise we might end up skipping layout of blocks that contain floats
that really need to be relaid out.

We get some marking for layout for free in layoutBlockFlow(), if
pageLogicalHeightChanged, but that only goes one level deep.
==========

[commit-bot: I haz the power, 2016-11-03 16:21:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-03 16:24:37]

Description was changed from

==========
logicalHeightWithVisibleOverflow() needs to include overhanging floats.

Otherwise we might end up skipping layout of blocks that contain floats
that really need to be relaid out.

We get some marking for layout for free in layoutBlockFlow(), if
pageLogicalHeightChanged, but that only goes one level deep.
==========

to

==========
logicalHeightWithVisibleOverflow() needs to include overhanging floats.

Otherwise we might end up skipping layout of blocks that contain floats
that really need to be relaid out.

We get some marking for layout for free in layoutBlockFlow(), if
pageLogicalHeightChanged, but that only goes one level deep.

Committed: https://crrev.com/22c5e1a6ac7251d197f48b4b6f17e4e6ef2f741c
Cr-Commit-Position: refs/heads/master@{#429611}
==========

[commit-bot: I haz the power, 2016-11-03 16:24:38]

Patchset 1 (id:??) landed as
https://crrev.com/22c5e1a6ac7251d197f48b4b6f17e4e6ef2f741c
Cr-Commit-Position: refs/heads/master@{#429611}