Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

Issue 2474883002: logicalHeightWithVisibleOverflow() needs to include overhanging floats. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
index c633ed2fc07dfc64fb31b29b623f75520fd98366..e01e173ded8e60e752d4e38d2ccabe63d410b76c 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
@@ -3905,6 +3905,11 @@ LayoutUnit LayoutBlockFlow::nextFloatLogicalBottomBelowForBlock(
logicalHeight);
}
+LayoutUnit LayoutBlockFlow::logicalHeightWithVisibleOverflow() const {
+ LayoutUnit logicalHeight = LayoutBlock::logicalHeightWithVisibleOverflow();
+ return std::max(logicalHeight, lowestFloatLogicalBottom());
+}
+
Node* LayoutBlockFlow::nodeForHitTest() const {
// If we are in the margins of block elements that are part of a
// continuation we're actually still inside the enclosing element
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlow.h ('k') | third_party/WebKit/Source/core/layout/LayoutBox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698