third_party/WebKit/Source/core/layout/LayoutBox.h - Issue 2474883002: logicalHeightWithVisibleOverflow() needs to include overhanging floats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 2474883002: logicalHeightWithVisibleOverflow() needs to include overhanging floats. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h

index 790230a9e380d6d515173442c5798280b9f69204..2c52af908d012228212fbcdd0dd817e3d82fd3ef 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h

@@ -254,7 +254,7 @@ class CORE_EXPORT LayoutBox : public LayoutBoxModelObject {

// Logical height of the object, including content overflowing the

// border-after edge.

- LayoutUnit logicalHeightWithVisibleOverflow() const;

+ virtual LayoutUnit logicalHeightWithVisibleOverflow() const;

LayoutUnit constrainLogicalWidthByMinMax(LayoutUnit,

LayoutUnit,

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp ('k') | no next file » | no next file with comments »