third_party/WebKit/Source/core/layout/LayoutBlockFlow.h - Issue 2474883002: logicalHeightWithVisibleOverflow() needs to include overhanging floats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

Issue 2474883002: logicalHeightWithVisibleOverflow() needs to include overhanging floats. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

index 89cff5807c64ac08f9a2b77384bf30d165cea7dd..0452ffb86a89c595f465ad9d42cd459aefcfa7ed 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

@@ -377,6 +377,8 @@ class CORE_EXPORT LayoutBlockFlow : public LayoutBlock {

return logicalBottomForFloat(floatObject) > logicalHeight();

}

+ LayoutUnit logicalHeightWithVisibleOverflow() const final;

// This function is only public so we can call it from NGBox while we're

// still working on LayoutNG.

void updateIsSelfCollapsing() {