third_party/WebKit/LayoutTests/fragmentation/overhanging-float-change-fragmentainer-height.html - Issue 2474883002: logicalHeightWithVisibleOverflow() needs to include overhanging floats.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fragmentation/overhanging-float-change-fragmentainer-height.html

Issue 2474883002: logicalHeightWithVisibleOverflow() needs to include overhanging floats. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <p>There should be a blue rectangle in the bottom left corner of a yellow rectan gle.</p>	2 <p>There should be a blue rectangle in the bottom left corner of a yellow rectan gle.</p>

3 <div id="multicol" style="position:relative; width:70px; columns:2; line-height: 20px; background:yellow;">	3 <div id="multicol" style="position:relative; width:70px; columns:2; column-fill: auto; height:50px; line-height:20px; background:yellow;">

4 <br>	4 <br>

5 <br>	5 <br>

6 <div id="elm" style="float:left; width:20px; margin-top:10px; background:blu e;"><br></div>	6 <div>

	7 <div>

	8 <div id="elm" style="float:left; width:20px; background:blue;"><br>< /div>

	9 </div>

	10 </div>

7 <div style="clear:both;">	11 <div style="clear:both;">

8 <br>	12 <br>

9 <br>	13 <br>

10 </div>	14 </div>

11 </div>	15 </div>

12 <script src="../../resources/testharness.js"></script>	16 <script src="../resources/testharness.js"></script>

13 <script src="../../resources/testharnessreport.js"></script>	17 <script src="../resources/testharnessreport.js"></script>

14 <script>	18 <script>

15 test(() => {	19 test(() => {

16 var multicol = document.getElementById("multicol");	20 var multicol = document.getElementById("multicol");

17 var elm = document.getElementById("elm");	21 var elm = document.getElementById("elm");

18 assert_equals(multicol.offsetHeight, 70);	22 document.body.offsetTop;

19 assert_equals(elm.offsetTop, 50);	23 multicol.style.height = "60px";

	24 assert_equals(elm.offsetTop, 40);

20 assert_equals(elm.offsetHeight, 20);	25 assert_equals(elm.offsetHeight, 20);

21 }, "Float that should fit at the bottom of the first column.");	26 }, "Float that should fit at the bottom of the first column.");

22 </script>	27 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlockFlow.h » ('j') | no next file with comments »