Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2474253002: Rename GpuPreferences::enable_unsafe_es3_apis to enable_es3_apis (Closed)

Created:
4 years, 1 month ago by Kai Ninomiya
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename GpuPreferences::enable_unsafe_es3_apis to enable_es3_apis This flag is not really "unsafe" - error checking is now complete. BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/879b20b77aff98ef980ad3261cf469cc23477b75 Cr-Commit-Position: refs/heads/master@{#430077}

Patch Set 1 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/common/gpu_host_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/context_group.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gpu_preferences.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
Kai Ninomiya
dcheng, rsesek: PTAL at content/common/gpu_host_messages.h zmo: PTAL
4 years, 1 month ago (2016-11-04 17:39:07 UTC) #6
dcheng
rs lgtm In the future, please just pick one IPC reviewer though
4 years, 1 month ago (2016-11-04 17:40:55 UTC) #7
Zhenyao Mo
On 2016/11/04 17:40:55, dcheng wrote: > rs lgtm > > In the future, please just ...
4 years, 1 month ago (2016-11-04 17:47:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474253002/20001
4 years, 1 month ago (2016-11-04 17:48:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/4948)
4 years, 1 month ago (2016-11-04 22:52:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474253002/20001
4 years, 1 month ago (2016-11-04 23:02:28 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-05 00:18:36 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 00:22:47 UTC) #18
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/879b20b77aff98ef980ad3261cf469cc23477b75
Cr-Commit-Position: refs/heads/master@{#430077}

Powered by Google App Engine
This is Rietveld 408576698