remove 'unsafe' from ES3 apis in gpu process

remove 'unsafe' from ES3 apis in gpu process

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/e20d23ac0473b75c2da272853dd4c7d9da09898f
Cr-Commit-Position: refs/heads/master@{#429491}

[Kai Ninomiya, 2016-11-02 20:13:52]

Description was changed from

==========
remove 'unsafe' from ES3 apis in gpu process

BUG=654787
==========

to

==========
remove 'unsafe' from ES3 apis in gpu process

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-11-02 20:14:41]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 20:15:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 21:13:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 21:13:24]

Dry run: This issue passed the CQ dry run.

[Kai Ninomiya, 2016-11-02 21:17:56]

kainino@chromium.org changed reviewers:
+ kbr@chromium.org, zmo@chromium.org

[Kai Ninomiya, 2016-11-02 21:17:56]

zmo, kbr: PTAL

(Please make sure I didn't modify too much in this CL)

[Zhenyao Mo, 2016-11-02 21:46:27]

zmo@chromium.org changed reviewers:
+ piman@chromium.org

[Zhenyao Mo, 2016-11-02 21:46:29]

This is a huge clean up in a messy situation. Thanks for working through the
mess.

Mostly look good.

https://codereview.chromium.org/2471853002/diff/1/content/browser/gpu/gpu_dat...
File content/browser/gpu/gpu_data_manager_impl_private.cc (right):

https://codereview.chromium.org/2471853002/diff/1/content/browser/gpu/gpu_dat...
content/browser/gpu/gpu_data_manager_impl_private.cc:703:
gpu_preferences->enable_unsafe_es3_apis = false;
Sorry I might mislead you. This switch is handling underlying GL context,
whereas GpuPreferences is handling command buffer context type. The former
enforces the latter, but not vice versa, so I think we still need to pass down
the kDisableES3GLContext.

https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/feature_info.cc (left):

https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:203:
command_line->HasSwitch(switches::kEnableUnsafeES3APIs) &&
Per our offline discussion, we need to hook up GpuPreferences with ContextGroup
and decide if we allow ES3/WebGL2 context types there.

https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/texture_manager_unittest.cc (right):

https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager_unittest.cc:108: enable_es3 ?
CONTEXT_TYPE_OPENGLES3 : CONTEXT_TYPE_OPENGLES2;
nit: wrong indent

https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager_unittest.cc:112: if
(feature_info_->IsWebGL2OrES3Context()) {
Can we ASSERT here?

https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager_unittest.cc:2201: enable_es3 ?
CONTEXT_TYPE_OPENGLES3 : CONTEXT_TYPE_OPENGLES2;
nit: wrong indent

https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager_unittest.cc:2205: if
(feature_info_->IsWebGL2OrES3Context()) {
Can we ASSERT here?

[piman, 2016-11-02 22:05:08]

https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:852: if (status_rgba ==
GL_FRAMEBUFFER_COMPLETE && enable_es3) {
I think we still expose the extension on ES2/WebGL1 contexts, if the underlying
context supports it, don't we?

https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:904: if
(enable_ext_color_buffer_float && enable_es3) {
ditto

[Zhenyao Mo, 2016-11-02 22:15:00]

https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:852: if (status_rgba ==
GL_FRAMEBUFFER_COMPLETE && enable_es3) {
On 2016/11/02 22:05:08, piman wrote:
> I think we still expose the extension on ES2/WebGL1 contexts, if the
underlying
> context supports it, don't we?

I checked the spec, the ES spec says it's ES3 extension. WebGL spec says it's
WebGL2 extension.  We might revisit in the future, but for now it is spec
compliant.

See:
https://www.khronos.org/registry/webgl/extensions/EXT_color_buffer_float/
https://www.khronos.org/registry/gles/extensions/EXT/EXT_color_buffer_float.txt

[piman, 2016-11-02 22:22:06]

On 2016/11/02 22:15:00, Zhenyao Mo wrote:
>
https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
> File gpu/command_buffer/service/feature_info.cc (right):
> 
>
https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
> gpu/command_buffer/service/feature_info.cc:852: if (status_rgba ==
> GL_FRAMEBUFFER_COMPLETE && enable_es3) {
> On 2016/11/02 22:05:08, piman wrote:
> > I think we still expose the extension on ES2/WebGL1 contexts, if the
> underlying
> > context supports it, don't we?
> 
> I checked the spec, the ES spec says it's ES3 extension. WebGL spec says it's
> WebGL2 extension.  We might revisit in the future, but for now it is spec
> compliant.

I see, it doesn't have the interaction with OES_texture_float specced. LGTM
then.

[Kai Ninomiya, 2016-11-02 22:43:21]

https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/texture_manager_unittest.cc (right):

https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager_unittest.cc:108: enable_es3 ?
CONTEXT_TYPE_OPENGLES3 : CONTEXT_TYPE_OPENGLES2;
On 2016/11/02 21:46:28, Zhenyao Mo wrote:
> nit: wrong indent

Done.

https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager_unittest.cc:112: if
(feature_info_->IsWebGL2OrES3Context()) {
On 2016/11/02 21:46:28, Zhenyao Mo wrote:
> Can we ASSERT here?

Done.

https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager_unittest.cc:2201: enable_es3 ?
CONTEXT_TYPE_OPENGLES3 : CONTEXT_TYPE_OPENGLES2;
On 2016/11/02 21:46:28, Zhenyao Mo wrote:
> nit: wrong indent

Done.

https://codereview.chromium.org/2471853002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager_unittest.cc:2205: if
(feature_info_->IsWebGL2OrES3Context()) {
On 2016/11/02 21:46:28, Zhenyao Mo wrote:
> Can we ASSERT here?

Done.

[Zhenyao Mo, 2016-11-02 22:49:58]

lgtm if the nit is fixed and bots are green

https://codereview.chromium.org/2471853002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/context_group.cc (right):

https://codereview.chromium.org/2471853002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/context_group.cc:123: context_type =
CONTEXT_TYPE_OPENGLES2;
You should print out a DLOG as the WEBGL2 case. No need to change context_type.

[Kai Ninomiya, 2016-11-02 23:42:48]

The CQ bit was checked by kainino@chromium.org

[Kai Ninomiya, 2016-11-02 23:42:48]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org,
zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2471853002/#ps40001
(title: "update")

[commit-bot: I haz the power, 2016-11-02 23:43:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2016-11-02 23:47:37]

The CQ bit was unchecked by kainino@chromium.org

[Kai Ninomiya, 2016-11-02 23:49:13]

The CQ bit was checked by kainino@chromium.org

[Kai Ninomiya, 2016-11-02 23:49:14]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2471853002/#ps60001
(title: "forgot to save file")

[commit-bot: I haz the power, 2016-11-02 23:49:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 01:04:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-03 01:06:26]

Description was changed from

==========
remove 'unsafe' from ES3 apis in gpu process

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
remove 'unsafe' from ES3 apis in gpu process

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/e20d23ac0473b75c2da272853dd4c7d9da09898f
Cr-Commit-Position: refs/heads/master@{#429491}
==========

[commit-bot: I haz the power, 2016-11-03 01:06:27]

Patchset 4 (id:??) landed as
https://crrev.com/e20d23ac0473b75c2da272853dd4c7d9da09898f
Cr-Commit-Position: refs/heads/master@{#429491}