command buffer: audit validation of ES3 commands (part 1)

command buffer: audit validation of ES3 commands (part 1)

Audit the validation (safety) of the first few ES3 command buffer commands - and switch the gating from 'unsafe_es3_apis_enabled()' to 'feature_info_->IsWebGL2OrES3Context' on newly audited commands.

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6e51299d296d504fb450dcdbb1814427cd62248f
Cr-Commit-Position: refs/heads/master@{#428499}

[Kai Ninomiya, 2016-10-27 22:25:34]

Description was changed from

==========
command buffer: ES3 commands: verify validation of first few commands

BUG=654787
==========

to

==========
command buffer: ES3 commands: verify validation of first few commands

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-10-27 22:29:53]

Description was changed from

==========
command buffer: ES3 commands: verify validation of first few commands

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
command buffer: ES3 commands: verify validation of first few commands

Verify the validation (safety) of the first few command buffer commands - and
switch them from 'unsafe_es3_apis_enabled()' to
'feature_info_->IsWebGL2OrES3Context'

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-10-27 22:31:28]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 22:32:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2016-10-27 22:56:53]

Description was changed from

==========
command buffer: ES3 commands: verify validation of first few commands

Verify the validation (safety) of the first few command buffer commands - and
switch them from 'unsafe_es3_apis_enabled()' to
'feature_info_->IsWebGL2OrES3Context'

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
command buffer: ES3 commands: verify validation of first few commands

Verify the validation (safety) of the first few ES3 command buffer commands -
and switch the gating from 'unsafe_es3_apis_enabled()' to
'feature_info_->IsWebGL2OrES3Context'

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-10-27 22:56:53]

kainino@chromium.org changed reviewers:
+ zmo@chromium.org

[commit-bot: I haz the power, 2016-10-27 23:55:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 23:55:45]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Kai Ninomiya, 2016-10-28 00:57:53]

Description was changed from

==========
command buffer: ES3 commands: verify validation of first few commands

Verify the validation (safety) of the first few ES3 command buffer commands -
and switch the gating from 'unsafe_es3_apis_enabled()' to
'feature_info_->IsWebGL2OrES3Context'

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
command buffer: ES3 commands: audit validation of first few commands

Audit the validation (safety) of the first few ES3 command buffer commands - and
switch the gating from 'unsafe_es3_apis_enabled()' to
'feature_info_->IsWebGL2OrES3Context' on audited commands.

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-10-28 01:25:59]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 01:26:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2016-10-28 01:26:51]

zmo, PTAL. I've audited all of those for which I changed the guard in this CL.

[Kai Ninomiya, 2016-10-28 01:28:34]

On 2016/10/28 01:26:51, Kai Ninomiya wrote:
> zmo, PTAL. I've audited all of those for which I changed the guard in this CL.

BTW, for some of the audits I just checked that the validation code was the same
for, e.g., 2D and 3D versions of the command.

[commit-bot: I haz the power, 2016-10-28 02:04:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 02:04:37]

Dry run: This issue passed the CQ dry run.

[Kai Ninomiya, 2016-10-28 19:07:04]

Description was changed from

==========
command buffer: ES3 commands: audit validation of first few commands

Audit the validation (safety) of the first few ES3 command buffer commands - and
switch the gating from 'unsafe_es3_apis_enabled()' to
'feature_info_->IsWebGL2OrES3Context' on audited commands.

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
command buffer: audit validation of ES3 commands (part 1)

Audit the validation (safety) of the first few ES3 command buffer commands - and
switch the gating from 'unsafe_es3_apis_enabled()' to
'feature_info_->IsWebGL2OrES3Context' on newly audited commands.

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-10-28 19:14:36]

On 2016/10/28 01:28:34, Kai Ninomiya wrote:
> On 2016/10/28 01:26:51, Kai Ninomiya wrote:
> > zmo, PTAL. I've audited all of those for which I changed the guard in this
CL.
> 
> BTW, for some of the audits I just checked that the validation code was the
same
> for, e.g., 2D and 3D versions of the command.

lgtm

[Kai Ninomiya, 2016-10-28 20:20:13]

The CQ bit was checked by kainino@chromium.org

[commit-bot: I haz the power, 2016-10-28 20:20:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 21:34:40]

Description was changed from

==========
command buffer: audit validation of ES3 commands (part 1)

Audit the validation (safety) of the first few ES3 command buffer commands - and
switch the gating from 'unsafe_es3_apis_enabled()' to
'feature_info_->IsWebGL2OrES3Context' on newly audited commands.

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
command buffer: audit validation of ES3 commands (part 1)

Audit the validation (safety) of the first few ES3 command buffer commands - and
switch the gating from 'unsafe_es3_apis_enabled()' to
'feature_info_->IsWebGL2OrES3Context' on newly audited commands.

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-28 21:34:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-28 21:38:03]

Description was changed from

==========
command buffer: audit validation of ES3 commands (part 1)

Audit the validation (safety) of the first few ES3 command buffer commands - and
switch the gating from 'unsafe_es3_apis_enabled()' to
'feature_info_->IsWebGL2OrES3Context' on newly audited commands.

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
command buffer: audit validation of ES3 commands (part 1)

Audit the validation (safety) of the first few ES3 command buffer commands - and
switch the gating from 'unsafe_es3_apis_enabled()' to
'feature_info_->IsWebGL2OrES3Context' on newly audited commands.

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6e51299d296d504fb450dcdbb1814427cd62248f
Cr-Commit-Position: refs/heads/master@{#428499}
==========

[commit-bot: I haz the power, 2016-10-28 21:38:04]

Patchset 2 (id:??) landed as
https://crrev.com/6e51299d296d504fb450dcdbb1814427cd62248f
Cr-Commit-Position: refs/heads/master@{#428499}

[please use gerrit instead, 2016-11-01 13:40:58]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2470663003/ by rouslan@chromium.org.

The reason for reverting is: Speculative revert for interacitve_ui_test flakes
on mac.

First failed build:
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/8412.