Enable WebGL 2 by default! (on desktop)

Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also mostly removes the "unsafe"/"experimental"/"prototype" wording from the flag and code. Auditing of validation for formerly-unsafe OpenGL ES3 APIs was done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

BUG=654787
BUG=295792
BUG=641635
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/61a4859d1d5a2f5082d486843c58a5b3f8795144
Cr-Commit-Position: refs/heads/master@{#429885}

[Kai Ninomiya, 2016-11-03 02:17:50]

Description was changed from

==========
Enable WebGL 2 by default! (on desktop)

BUG=654787
==========

to

==========
Enable WebGL 2 by default! (on desktop)

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-11-03 02:18:10]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 02:18:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 02:51:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 02:51:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Kai Ninomiya, 2016-11-03 16:47:56]

Description was changed from

==========
Enable WebGL 2 by default! (on desktop)

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in
about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also removes the "unsafe"/"experimental"/"prototype" wording from the
flag and code. Auditing of validation for formerly-unsafe OpenGL ES3 APIs was
done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-11-03 16:51:10]

Description was changed from

==========
Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in
about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also removes the "unsafe"/"experimental"/"prototype" wording from the
flag and code. Auditing of validation for formerly-unsafe OpenGL ES3 APIs was
done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in
about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also removes the "unsafe"/"experimental"/"prototype" wording from the
flag and code. Auditing of validation for formerly-unsafe OpenGL ES3 APIs was
done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

BUG=654787
BUG=295792
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-11-03 16:58:10]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 16:58:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2016-11-03 17:12:22]

Description was changed from

==========
Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in
about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also removes the "unsafe"/"experimental"/"prototype" wording from the
flag and code. Auditing of validation for formerly-unsafe OpenGL ES3 APIs was
done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

BUG=654787
BUG=295792
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in
about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also removes the "unsafe"/"experimental"/"prototype" wording from the
flag and code. Auditing of validation for formerly-unsafe OpenGL ES3 APIs was
done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

BUG=654787
BUG=295792
BUG=641635
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-03 17:38:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 17:38:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Kai Ninomiya, 2016-11-03 20:11:23]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 20:12:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 20:46:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 20:46:27]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Kai Ninomiya, 2016-11-03 21:23:54]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[Kai Ninomiya, 2016-11-03 21:24:15]

kainino@chromium.org changed reviewers:
+ kbr@chromium.org, zmo@chromium.org

[commit-bot: I haz the power, 2016-11-03 21:24:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2016-11-03 21:37:11]

zmo, kbr: PTAL

[Ken Russell (switch to Gerrit), 2016-11-03 21:50:42]

This is awesome!

LGTM. The logic looks correct. I had a concern about the updating of the
GpuPreferences, but upon closer look it seems correct.

A couple of minor comments.

Note: I'm not an OWNER of all of these directories. Please scan them to find
appropriate owners.

https://codereview.chromium.org/2473933002/diff/60001/content/public/browser/...
File content/public/browser/gpu_utils.cc (left):

https://codereview.chromium.org/2473933002/diff/60001/content/public/browser/...
content/public/browser/gpu_utils.cc:110:
!command_line->HasSwitch(switches::kDisableES3APIs);
Could you add a comment here (perhaps at the very end) that some of these
preferences, including enable_es3_apis, are adjusted in
GpuDataManagerImplPrivate::AppendGpuCommandLine ?

https://codereview.chromium.org/2473933002/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gpu_preferences.h (right):

https://codereview.chromium.org/2473933002/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/gpu_preferences.h:137: // Enable OpenGL ES 3 APIs
without proper service side validation.
Comment needs to be updated. "Enable OpenGL ES 3 APIs."

[piman, 2016-11-03 21:58:29]

piman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2016-11-03 21:58:29]

https://codereview.chromium.org/2473933002/diff/60001/gpu/command_buffer/test...
File gpu/command_buffer/tests/fuzzer_main.cc (right):

https://codereview.chromium.org/2473933002/diff/60001/gpu/command_buffer/test...
gpu/command_buffer/tests/fuzzer_main.cc:95: gpu_preferences_.enable_es3_apis =
true;
nit: you made it the default, so that's not needed any more.

https://codereview.chromium.org/2473933002/diff/60001/ui/gl/gl_context_wgl.cc
File ui/gl/gl_context_wgl.cc (right):

https://codereview.chromium.org/2473933002/diff/60001/ui/gl/gl_context_wgl.cc...
ui/gl/gl_context_wgl.cc:35: switches::kEnableES3APIs);
Should this be
!base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kDisableES3GLContext)
like for egl?

I don't think this switch is forwarded to the GPU process.

[piman, 2016-11-03 22:00:11]

One note, crbug.com/661868 just popped up by the fuzzer, and would be a
security issue - can we hold on for a fix for that?

On Thu, Nov 3, 2016 at 2:58 PM, <piman@chromium.org> wrote:

>
> https://codereview.chromium.org/2473933002/diff/60001/gpu/
> command_buffer/tests/fuzzer_main.cc
> File gpu/command_buffer/tests/fuzzer_main.cc (right):
>
> https://codereview.chromium.org/2473933002/diff/60001/gpu/
> command_buffer/tests/fuzzer_main.cc#newcode95
> gpu/command_buffer/tests/fuzzer_main.cc:95:
> gpu_preferences_.enable_es3_apis = true;
> nit: you made it the default, so that's not needed any more.
>
> https://codereview.chromium.org/2473933002/diff/60001/ui/
> gl/gl_context_wgl.cc
> File ui/gl/gl_context_wgl.cc (right):
>
> https://codereview.chromium.org/2473933002/diff/60001/ui/
> gl/gl_context_wgl.cc#newcode35
> ui/gl/gl_context_wgl.cc:35: switches::kEnableES3APIs);
> Should this be
> !base::CommandLine::ForCurrentProcess()->HasSwitch(switches::
> kDisableES3GLContext)
> like for egl?
>
> I don't think this switch is forwarded to the GPU process.
>
> https://codereview.chromium.org/2473933002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Kai Ninomiya, 2016-11-03 22:10:06]

https://codereview.chromium.org/2473933002/diff/60001/content/public/browser/...
File content/public/browser/gpu_utils.cc (left):

https://codereview.chromium.org/2473933002/diff/60001/content/public/browser/...
content/public/browser/gpu_utils.cc:110:
!command_line->HasSwitch(switches::kDisableES3APIs);
On 2016/11/03 21:50:42, Ken Russell wrote:
> Could you add a comment here (perhaps at the very end) that some of these
> preferences, including enable_es3_apis, are adjusted in
> GpuDataManagerImplPrivate::AppendGpuCommandLine ?

Done.

https://codereview.chromium.org/2473933002/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gpu_preferences.h (right):

https://codereview.chromium.org/2473933002/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/gpu_preferences.h:137: // Enable OpenGL ES 3 APIs
without proper service side validation.
On 2016/11/03 21:50:42, Ken Russell wrote:
> Comment needs to be updated. "Enable OpenGL ES 3 APIs."

Done.

https://codereview.chromium.org/2473933002/diff/60001/gpu/command_buffer/test...
File gpu/command_buffer/tests/fuzzer_main.cc (right):

https://codereview.chromium.org/2473933002/diff/60001/gpu/command_buffer/test...
gpu/command_buffer/tests/fuzzer_main.cc:95: gpu_preferences_.enable_es3_apis =
true;
On 2016/11/03 21:58:29, piman wrote:
> nit: you made it the default, so that's not needed any more.

Done.

https://codereview.chromium.org/2473933002/diff/60001/ui/gl/gl_context_wgl.cc
File ui/gl/gl_context_wgl.cc (right):

https://codereview.chromium.org/2473933002/diff/60001/ui/gl/gl_context_wgl.cc...
ui/gl/gl_context_wgl.cc:35: switches::kEnableES3APIs);
On 2016/11/03 21:58:29, piman wrote:
> Should this be
>
!base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kDisableES3GLContext)
> like for egl?
> 
> I don't think this switch is forwarded to the GPU process.

Good catch, thanks!

[Kai Ninomiya, 2016-11-03 22:11:01]

On 2016/11/03 21:50:42, Ken Russell wrote:
> Note: I'm not an OWNER of all of these directories. Please scan them to find
> appropriate owners.

I will; I was waiting for a sanity check from the dry run before pushing it out
to the remainder of the reviewers.

[Kai Ninomiya, 2016-11-03 22:22:59]

Description was changed from

==========
Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in
about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also removes the "unsafe"/"experimental"/"prototype" wording from the
flag and code. Auditing of validation for formerly-unsafe OpenGL ES3 APIs was
done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

BUG=654787
BUG=295792
BUG=641635
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in
about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also removes the "unsafe"/"experimental"/"prototype" wording from the
flag and code. Auditing of validation for formerly-unsafe OpenGL ES3 APIs was
done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

// Blocked on http://crbug.com/661868
COMMIT=false
BUG=654787
BUG=295792
BUG=641635
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-11-03 22:26:55]

LGTM after https://codereview.chromium.org/2475793002 lands

[Kai Ninomiya, 2016-11-03 22:30:11]

kainino@chromium.org changed reviewers:
+ haraken@chromium.org

[Kai Ninomiya, 2016-11-03 22:30:11]

haraken, PTAL:
* tools/metrics/histograms/histograms.xml

Thanks!

[Kai Ninomiya, 2016-11-03 22:41:40]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 22:42:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2016-11-03 22:47:17]

Description was changed from

==========
Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in
about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also removes the "unsafe"/"experimental"/"prototype" wording from the
flag and code. Auditing of validation for formerly-unsafe OpenGL ES3 APIs was
done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

// Blocked on http://crbug.com/661868
COMMIT=false
BUG=654787
BUG=295792
BUG=641635
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in
about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also mostly removes the "unsafe"/"experimental"/"prototype" wording
from the flag and code. Auditing of validation for formerly-unsafe OpenGL ES3
APIs was done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

// Blocked on http://crbug.com/661868
COMMIT=false
BUG=654787
BUG=295792
BUG=641635
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-11-03 23:02:52]

On 2016/11/03 22:30:11, Kai Ninomiya wrote:
> haraken, PTAL:
> * tools/metrics/histograms/histograms.xml
> 
> Thanks!

lgtm

[haraken, 2016-11-03 23:14:59]

LGTM

[Kai Ninomiya, 2016-11-03 23:17:06]

The CQ bit was unchecked by kainino@chromium.org

[Kai Ninomiya, 2016-11-03 23:17:24]

The CQ bit was checked by kainino@chromium.org

[Kai Ninomiya, 2016-11-03 23:17:24]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2473933002/#ps100001
(title: "undo rename of GpuPreferences::enable_unsafe_es3_apis")

[Kai Ninomiya, 2016-11-03 23:17:47]

The CQ bit was unchecked by kainino@chromium.org

[Kai Ninomiya, 2016-11-03 23:17:54]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[Kai Ninomiya, 2016-11-03 23:18:18]

Description was changed from

==========
Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in
about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also mostly removes the "unsafe"/"experimental"/"prototype" wording
from the flag and code. Auditing of validation for formerly-unsafe OpenGL ES3
APIs was done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

// Blocked on http://crbug.com/661868
COMMIT=false
BUG=654787
BUG=295792
BUG=641635
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in
about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also mostly removes the "unsafe"/"experimental"/"prototype" wording
from the flag and code. Auditing of validation for formerly-unsafe OpenGL ES3
APIs was done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

// Blocked on https://codereview.chromium.org/2475793002
COMMIT=false
BUG=654787
BUG=295792
BUG=641635
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-03 23:18:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 02:33:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 02:33:34]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Kai Ninomiya, 2016-11-04 02:58:34]

The CQ bit was checked by kainino@chromium.org

[commit-bot: I haz the power, 2016-11-04 02:59:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 02:59:43]

COMMIT=false detected. CQ is abandoning the patch.

[Kai Ninomiya, 2016-11-04 03:01:53]

Description was changed from

==========
Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in
about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also mostly removes the "unsafe"/"experimental"/"prototype" wording
from the flag and code. Auditing of validation for formerly-unsafe OpenGL ES3
APIs was done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

// Blocked on https://codereview.chromium.org/2475793002
COMMIT=false
BUG=654787
BUG=295792
BUG=641635
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in
about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also mostly removes the "unsafe"/"experimental"/"prototype" wording
from the flag and code. Auditing of validation for formerly-unsafe OpenGL ES3
APIs was done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

BUG=654787
BUG=295792
BUG=641635
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-11-04 03:02:24]

The CQ bit was checked by kainino@chromium.org

[commit-bot: I haz the power, 2016-11-04 03:03:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 06:17:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 06:17:55]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Zhenyao Mo, 2016-11-04 13:57:07]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-11-04 13:57:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 14:59:44]

Description was changed from

==========
Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in
about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also mostly removes the "unsafe"/"experimental"/"prototype" wording
from the flag and code. Auditing of validation for formerly-unsafe OpenGL ES3
APIs was done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

BUG=654787
BUG=295792
BUG=641635
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in
about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also mostly removes the "unsafe"/"experimental"/"prototype" wording
from the flag and code. Auditing of validation for formerly-unsafe OpenGL ES3
APIs was done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

BUG=654787
BUG=295792
BUG=641635
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-04 14:59:45]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-04 15:01:58]

Description was changed from

==========
Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in
about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also mostly removes the "unsafe"/"experimental"/"prototype" wording
from the flag and code. Auditing of validation for formerly-unsafe OpenGL ES3
APIs was done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

BUG=654787
BUG=295792
BUG=641635
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable WebGL 2 by default! (on desktop)

This patch creates a feature-style (Default/Enabled/Disabled) entry in
about:flags for WebGL 2. Default is enabled on desktop and disabled on Android.

This patch also mostly removes the "unsafe"/"experimental"/"prototype" wording
from the flag and code. Auditing of validation for formerly-unsafe OpenGL ES3
APIs was done in:
https://codereview.chromium.org/2458523005/
https://codereview.chromium.org/2461023002/
https://codereview.chromium.org/2470623002/
https://codereview.chromium.org/2466763002/
And the flag was removed from the GPU process in:
https://codereview.chromium.org/2471853002/

BUG=654787
BUG=295792
BUG=641635
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/61a4859d1d5a2f5082d486843c58a5b3f8795144
Cr-Commit-Position: refs/heads/master@{#429885}
==========

[commit-bot: I haz the power, 2016-11-04 15:01:59]

Patchset 6 (id:??) landed as
https://crrev.com/61a4859d1d5a2f5082d486843c58a5b3f8795144
Cr-Commit-Position: refs/heads/master@{#429885}