Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2461023002:
command buffer: audit validation of ES3 commands (part 2) (Closed)
|
Created:
4 years, 1 month ago by Kai Ninomiya Modified:
4 years, 1 month ago Reviewers:
Zhenyao Mo CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit) Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptioncommand buffer: audit validation of ES3 commands (part 2)
Add some validation, and switch the gating from 'unsafe_es3_apis_enabled()' to
'feature_info_->IsWebGL2OrES3Context' on the newly audited commands.
BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/7141360bbdadb8e29229f2b785a533abce6795c0
Cr-Commit-Position: refs/heads/master@{#428528}
Patch Set 1 #Patch Set 2 : fix #Patch Set 3 : update mocked unittests #
Messages
Total messages: 25 (16 generated)
Description was changed from ========== command buffer: ES3 commands: audit validation of next few commands Add some validation, and switch the gating from 'unsafe_es3_apis_enabled()' to 'feature_info_->IsWebGL2OrES3Context' on the newly audited commands. BUG=654787 ========== to ========== command buffer: ES3 commands: audit validation of next few commands Add some validation, and switch the gating from 'unsafe_es3_apis_enabled()' to 'feature_info_->IsWebGL2OrES3Context' on the newly audited commands. BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by kainino@chromium.org to run a CQ dry run
kainino@chromium.org changed reviewers: + zmo@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== command buffer: ES3 commands: audit validation of next few commands Add some validation, and switch the gating from 'unsafe_es3_apis_enabled()' to 'feature_info_->IsWebGL2OrES3Context' on the newly audited commands. BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== command buffer: audit validation of ES3 commands (part 2) Add some validation, and switch the gating from 'unsafe_es3_apis_enabled()' to 'feature_info_->IsWebGL2OrES3Context' on the newly audited commands. BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
lgtm nice work
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by kainino@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org Link to the patchset: https://codereview.chromium.org/2461023002/#ps20001 (title: "fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by kainino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
zmo: thanks, can you now take a look at the tests which I just added?
On 2016/10/28 21:19:26, Kai Ninomiya wrote: > zmo: thanks, can you now take a look at the tests which I just added? still lgtm
The CQ bit was unchecked by kainino@chromium.org
The CQ bit was checked by kainino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== command buffer: audit validation of ES3 commands (part 2) Add some validation, and switch the gating from 'unsafe_es3_apis_enabled()' to 'feature_info_->IsWebGL2OrES3Context' on the newly audited commands. BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== command buffer: audit validation of ES3 commands (part 2) Add some validation, and switch the gating from 'unsafe_es3_apis_enabled()' to 'feature_info_->IsWebGL2OrES3Context' on the newly audited commands. BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== command buffer: audit validation of ES3 commands (part 2) Add some validation, and switch the gating from 'unsafe_es3_apis_enabled()' to 'feature_info_->IsWebGL2OrES3Context' on the newly audited commands. BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== command buffer: audit validation of ES3 commands (part 2) Add some validation, and switch the gating from 'unsafe_es3_apis_enabled()' to 'feature_info_->IsWebGL2OrES3Context' on the newly audited commands. BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/7141360bbdadb8e29229f2b785a533abce6795c0 Cr-Commit-Position: refs/heads/master@{#428528} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/7141360bbdadb8e29229f2b785a533abce6795c0 Cr-Commit-Position: refs/heads/master@{#428528} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
