Revert of Initialize buffers before allowing access to them.

Revert of Initialize buffers before allowing access to them. (patchset #8 id:140001 of https://codereview.chromium.org/2435803004/ )

Reason for revert:
This regresses WebGL performance on Chrome OS devices (see bug).

BUG=661186
Original issue's description:
> Initialize buffers before allowing access to them.
> 
> Also, refactor buffer access validation a bit to reduce
> duplicated codes.
> 
> (Note that this is still part 1 of the work. We have more
> buffer access paths that we need to put in buffer access
> validation.)
> 
> BUG=654201
> TEST=gpu_unittests, webgl_conformance
> R=piman@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/26c35c2e81f97a5b291ebd4d639fc3f1a4cc50e8
> Cr-Commit-Position: refs/heads/master@{#427200}

TBR=piman@chromium.org,zmo@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=654201

[marcheu, 2016-11-01 20:20:58]

Created Revert of Initialize buffers before allowing access to them.

[Ken Russell (switch to Gerrit), 2016-11-01 20:22:44]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-11-01 20:22:44]

Please don't revert this. It's needed for security reasons.

[marcheu, 2016-11-01 20:25:44]

On 2016/11/01 20:22:44, Ken Russell wrote:
> Please don't revert this. It's needed for security reasons.

It is causing a major performance regression though, so as such it can be
reverted...

[Zhenyao Mo, 2016-11-01 20:44:49]

On 2016/11/01 20:25:44, marcheu wrote:
> On 2016/11/01 20:22:44, Ken Russell wrote:
> > Please don't revert this. It's needed for security reasons.
> 
> It is causing a major performance regression though, so as such it can be
> reverted...

We are looking at fixing it right now.  Please don't revert this CL.

[Ken Russell (switch to Gerrit), 2016-11-01 20:52:41]

On 2016/11/01 20:44:49, Zhenyao Mo wrote:
> On 2016/11/01 20:25:44, marcheu wrote:
> > On 2016/11/01 20:22:44, Ken Russell wrote:
> > > Please don't revert this. It's needed for security reasons.
> > 
> > It is causing a major performance regression though, so as such it can be
> > reverted...
> 
> We are looking at fixing it right now.  Please don't revert this CL.

I've taken the bug and am fixing it now. Let me close this so it isn't
accidentally landed. I doubt it would land cleanly at this point anyway.

[Ken Russell (switch to Gerrit), 2016-11-01 20:52:45]

Description was changed from

==========
Revert of Initialize buffers before allowing access to them. (patchset #8
id:140001 of https://codereview.chromium.org/2435803004/ )

Reason for revert:
This regresses WebGL performance on Chrome OS devices (see bug).

BUG=661186

Original issue's description:
> Initialize buffers before allowing access to them.
> 
> Also, refactor buffer access validation a bit to reduce
> duplicated codes.
> 
> (Note that this is still part 1 of the work. We have more
> buffer access paths that we need to put in buffer access
> validation.)
> 
> BUG=654201
> TEST=gpu_unittests, webgl_conformance
> R=piman@chromium.org
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/26c35c2e81f97a5b291ebd4d639fc3f1a4cc50e8
> Cr-Commit-Position: refs/heads/master@{#427200}

TBR=piman@chromium.org,zmo@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=654201
==========

to

==========
Revert of Initialize buffers before allowing access to them. (patchset #8
id:140001 of https://codereview.chromium.org/2435803004/ )

Reason for revert:
This regresses WebGL performance on Chrome OS devices (see bug).

BUG=661186

Original issue's description:
> Initialize buffers before allowing access to them.
> 
> Also, refactor buffer access validation a bit to reduce
> duplicated codes.
> 
> (Note that this is still part 1 of the work. We have more
> buffer access paths that we need to put in buffer access
> validation.)
> 
> BUG=654201
> TEST=gpu_unittests, webgl_conformance
> R=piman@chromium.org
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/26c35c2e81f97a5b291ebd4d639fc3f1a4cc50e8
> Cr-Commit-Position: refs/heads/master@{#427200}

TBR=piman@chromium.org,zmo@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=654201
==========