Revert of Initialize buffers before allowing access to them.

gpu/command_buffer/service/buffer_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 
 #include "gpu/command_buffer/service/buffer_manager.h"
@@ skipping 43 matching lines @@
       Buffer* buffer, GLenum target, GLsizeiptr size, GLenum usage,
       const GLvoid* data, GLenum error) {
     TestHelper::DoBufferData(
         gl_.get(), error_state_.get(), manager_.get(),
         buffer, target, size, usage, data, error);
   }
 
   bool DoBufferSubData(
       Buffer* buffer, GLenum target, GLintptr offset, GLsizeiptr size,
       const GLvoid* data) {
+    bool success = true;
     if (!buffer->CheckRange(offset, size)) {
-      return false;
-    }
-    if (!buffer->IsClientSideArray()) {
+      EXPECT_CALL(*error_state_, SetGLError(_, _, GL_INVALID_VALUE, _, _))
+         .Times(1)
+         .RetiresOnSaturation();
+      success = false;
+    } else if (!buffer->IsClientSideArray()) {
       EXPECT_CALL(*gl_, BufferSubData(target, offset, size, _))
           .Times(1)
           .RetiresOnSaturation();
     }
-    manager_->DoBufferSubData(buffer, target, offset, size, data);
-    return true;
+    manager_->DoBufferSubData(
+        error_state_.get(), buffer, target, offset, size, data);
+    return success;
   }
 
   void RunGetMaxValueForRangeUint8Test(bool enable_primitive_restart)
   {
     const GLenum kTarget = GL_ELEMENT_ARRAY_BUFFER;
     const GLuint kClientBufferId = 1;
     const GLuint kServiceBufferId = 11;
     const uint8_t data[] = {10, 9, 8, 7, 6, 0xFFu, 4, 3, 2, 1};
     const uint8_t new_data[] = {100, 120, 110};
     manager_->CreateBuffer(kClientBufferId, kServiceBufferId);
@@ skipping 494 matching lines @@
   // Removing buffers after MarkContextLost cause no GL calls.
   manager_->RemoveBuffer(kClient1Id);
   manager_->Destroy();
   // Check the resources were released.
   buffer1 = manager_->GetBuffer(kClient1Id);
   ASSERT_TRUE(buffer1 == nullptr);
 }
 
 }  // namespace gles2
 }  // namespace gpu
+
+