Initialize buffers before allowing access to them.

Initialize buffers before allowing access to them.

Also, refactor buffer access validation a bit to reduce
duplicated codes.

(Note that this is still part 1 of the work. We have more
buffer access paths that we need to put in buffer access
validation.)

BUG=654201
TEST=gpu_unittests, webgl_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/26c35c2e81f97a5b291ebd4d639fc3f1a4cc50e8
Cr-Commit-Position: refs/heads/master@{#427200}

[Zhenyao Mo, 2016-10-19 18:54:23]

Description was changed from

==========
Initialize buffers before allowing access to them.

BUG=654201
TEST=gpu_unittests, webgl_conformance
R=piman@chromium.org
==========

to

==========
Initialize buffers before allowing access to them.

BUG=654201
TEST=gpu_unittests, webgl_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-10-19 23:00:28]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 23:01:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-10-19 23:01:41]

Description was changed from

==========
Initialize buffers before allowing access to them.

BUG=654201
TEST=gpu_unittests, webgl_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Initialize buffers before allowing access to them.

Also, refactor buffer access validation a bit to reduce
duplicated codes.

(Note that this is still part 1 of the work. We have more
buffer access paths that we need to put in buffer access
validation.)

BUG=654201
TEST=gpu_unittests, webgl_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-10-19 23:31:06]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 23:31:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 00:58:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 00:58:19]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Zhenyao Mo, 2016-10-21 22:48:20]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 22:49:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 22:52:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 22:52:45]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Zhenyao Mo, 2016-10-21 22:56:40]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 22:57:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 01:07:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 01:07:02]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Zhenyao Mo, 2016-10-22 01:38:20]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-22 01:38:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-10-22 01:39:03]

piman: please review.
others: FYI

(Note that https://bugs.chromium.org/p/angleproject/issues/detail?id=1555 is
created for the new WebGL2 test failure - I think it's a bug in ANGLE)

[commit-bot: I haz the power, 2016-10-22 05:16:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 05:16:01]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Zhenyao Mo, 2016-10-24 21:54:53]

On 2016/10/22 01:39:03, Zhenyao Mo wrote:
> piman: please review.
> others: FYI
> 
> (Note that https://bugs.chromium.org/p/angleproject/issues/detail?id=1555 is
> created for the new WebGL2 test failure - I think it's a bug in ANGLE)

All bots are green now.

[Ken Russell (switch to Gerrit), 2016-10-24 22:04:07]

On 2016/10/24 21:54:53, Zhenyao Mo wrote:
> On 2016/10/22 01:39:03, Zhenyao Mo wrote:
> > piman: please review.
> > others: FYI
> > 
> > (Note that https://bugs.chromium.org/p/angleproject/issues/detail?id=1555 is
> > created for the new WebGL2 test failure - I think it's a bug in ANGLE)
> 
> All bots are green now.

Excellent work!!!

[piman, 2016-10-24 22:47:11]

LGTM, nice cleanup!

https://codereview.chromium.org/2435803004/diff/140001/gpu/command_buffer/ser...
File gpu/command_buffer/service/buffer_manager.h (right):

https://codereview.chromium.org/2435803004/diff/140001/gpu/command_buffer/ser...
gpu/command_buffer/service/buffer_manager.h:321: uint32_t mapped_buffer_count()
const {
nit: I didn't see being used. Is that for a follow-up?

[Zhenyao Mo, 2016-10-24 22:54:28]

On 2016/10/24 22:47:11, piman wrote:
> LGTM, nice cleanup!
> 
>
https://codereview.chromium.org/2435803004/diff/140001/gpu/command_buffer/ser...
> File gpu/command_buffer/service/buffer_manager.h (right):
> 
>
https://codereview.chromium.org/2435803004/diff/140001/gpu/command_buffer/ser...
> gpu/command_buffer/service/buffer_manager.h:321: uint32_t
mapped_buffer_count()
> const {
> nit: I didn't see being used. Is that for a follow-up?

Hopefully it can make UNIFORM_BUFFER bindings checking efficient, which isn't
implemented yet.

[Zhenyao Mo, 2016-10-24 22:54:38]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-10-24 22:55:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 23:13:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 23:13:16]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Zhenyao Mo, 2016-10-24 23:15:19]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-10-24 23:16:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 01:00:18]

Description was changed from

==========
Initialize buffers before allowing access to them.

Also, refactor buffer access validation a bit to reduce
duplicated codes.

(Note that this is still part 1 of the work. We have more
buffer access paths that we need to put in buffer access
validation.)

BUG=654201
TEST=gpu_unittests, webgl_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Initialize buffers before allowing access to them.

Also, refactor buffer access validation a bit to reduce
duplicated codes.

(Note that this is still part 1 of the work. We have more
buffer access paths that we need to put in buffer access
validation.)

BUG=654201
TEST=gpu_unittests, webgl_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-25 01:00:20]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-10-25 01:03:41]

Description was changed from

==========
Initialize buffers before allowing access to them.

Also, refactor buffer access validation a bit to reduce
duplicated codes.

(Note that this is still part 1 of the work. We have more
buffer access paths that we need to put in buffer access
validation.)

BUG=654201
TEST=gpu_unittests, webgl_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Initialize buffers before allowing access to them.

Also, refactor buffer access validation a bit to reduce
duplicated codes.

(Note that this is still part 1 of the work. We have more
buffer access paths that we need to put in buffer access
validation.)

BUG=654201
TEST=gpu_unittests, webgl_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/26c35c2e81f97a5b291ebd4d639fc3f1a4cc50e8
Cr-Commit-Position: refs/heads/master@{#427200}
==========

[commit-bot: I haz the power, 2016-10-25 01:03:42]

Patchset 8 (id:??) landed as
https://crrev.com/26c35c2e81f97a5b291ebd4d639fc3f1a4cc50e8
Cr-Commit-Position: refs/heads/master@{#427200}

[marcheu, 2016-11-01 20:20:57]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2469803003/ by marcheu@chromium.org.

The reason for reverting is: This regresses WebGL performance on Chrome OS
devices (see bug).

BUG=661186.