Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2468653002: Remove GrStencilSettings from GrPipeline (Closed)

Created:
4 years, 1 month ago by csmartdalton
Modified:
4 years, 1 month ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove GrStencilSettings from GrPipeline Updates the GrPipeline to have user stencil settings instead of actual settings. This allows us to further defer creating and attaching a stencil buffer. This change is a partial step. The ultimate goal is to attach the stencil buffer and create the stencil settings during render target flush, but for the sake of keeping this CL smaller, we create the stencil settings right before use for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2468653002 Committed: https://skia.googlesource.com/skia/+/c633abbb342e3af0e56382e8cb7e7d9fed71e237

Patch Set 1 #

Patch Set 2 : Add dependency for 2467593002 #

Patch Set 3 : actually add the dependency this time (?) #

Patch Set 4 : Remove GrStencilSettings from GrPipeline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -64 lines) Patch
M src/gpu/GrGpu.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 2 chunks +11 lines, -2 lines 0 comments Download
M src/gpu/GrPipeline.h View 5 chunks +7 lines, -3 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 4 chunks +9 lines, -10 lines 0 comments Download
M src/gpu/GrProgramDesc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrReducedClip.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrRenderTarget.cpp View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M src/gpu/GrRenderTargetPriv.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrStencilSettings.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrUserStencilSettings.h View 1 chunk +16 lines, -0 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 1 chunk +9 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/instanced/InstanceProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkPipeline.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkPipeline.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/vk/GrVkPipelineState.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/vk/GrVkPipelineState.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/vk/GrVkPipelineStateBuilder.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/vk/GrVkPipelineStateBuilder.cpp View 4 chunks +5 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkPipelineStateCache.cpp View 1 2 3 3 chunks +13 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkResourceProvider.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/vk/GrVkResourceProvider.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/GpuSampleLocationsTest.cpp View 4 chunks +42 lines, -23 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
csmartdalton
4 years, 1 month ago (2016-10-31 19:25:16 UTC) #3
csmartdalton
Give me a minute to try and break out a smaller CL or two...
4 years, 1 month ago (2016-10-31 19:30:47 UTC) #4
csmartdalton
Ok this is more straightforward now.
4 years, 1 month ago (2016-10-31 20:41:26 UTC) #5
bsalomon
lgtm
4 years, 1 month ago (2016-11-01 13:20:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468653002/60001
4 years, 1 month ago (2016-11-01 15:30:56 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 15:55:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c633abbb342e3af0e56382e8cb7e7d9fed71e237

Powered by Google App Engine
This is Rietveld 408576698