Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2467593002: Move memoization of multisample specs id to GrRenderTarget (Closed)

Created:
4 years, 1 month ago by csmartdalton
Modified:
4 years, 1 month ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move memoization of multisample specs id to GrRenderTarget GrGpu used to perform the memoization on behalf of GrRenderTarget via a public accessor. This change updates GrRenderTarget to do its own work. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2467593002 Committed: https://skia.googlesource.com/skia/+/c25c5d73e9f4d840dc758c399496d5690709ad58

Patch Set 1 #

Patch Set 2 : Move memoization of multisample specs id to GrRenderTarget #

Patch Set 3 : Move memoization of multisample specs id to GrRenderTarget #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -32 lines) Patch
M src/gpu/GrGpu.h View 2 chunks +12 lines, -6 lines 0 comments Download
M src/gpu/GrGpu.cpp View 2 chunks +3 lines, -14 lines 0 comments Download
M src/gpu/GrRenderTarget.cpp View 1 chunk +8 lines, -1 line 0 comments Download
M src/gpu/GrRenderTargetPriv.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkGpu.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gpu/GrTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
csmartdalton
4 years, 1 month ago (2016-10-31 20:17:28 UTC) #3
bsalomon
lgtm
4 years, 1 month ago (2016-11-01 13:16:04 UTC) #4
robertphillips
lgtm
4 years, 1 month ago (2016-11-01 13:23:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467593002/40001
4 years, 1 month ago (2016-11-01 13:43:29 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 14:04:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c25c5d73e9f4d840dc758c399496d5690709ad58

Powered by Google App Engine
This is Rietveld 408576698