Android: Add connection security summary to page info popup

Android: Add connection security summary to page info popup

This adds a short summary message to the page info popup to explain the
security state of a page, along with the existing longer description.
These strings are now generated by the same C++ code which runs on
desktop, removing the need for most of the Android-specific strings and
logic.

BUG=657148
Committed: https://crrev.com/7ec4b62739fca0380d6de17feb58d6f537983dbe
Cr-Commit-Position: refs/heads/master@{#429729}

[tsergeant, 2016-11-03 04:32:24]

Description was changed from

==========
Android: Expand connection summary text in page info popup

BUG=657148
==========

to

==========
Android: Add connection security summary to page info popup

This adds a short summary message to the page info popup to explain the
security state of a page, along with the existing longer description.
These strings are now generated by the same C++ code which runs on
desktop, removing the need for most of the Android-specific strings and
logic.

BUG=657148
==========

[tsergeant, 2016-11-03 04:32:44]

Description was changed from

==========
Android: Add connection security summary to page info popup

This adds a short summary message to the page info popup to explain the
security state of a page, along with the existing longer description.
These strings are now generated by the same C++ code which runs on
desktop, removing the need for most of the Android-specific strings and
logic.

BUG=657148
==========

to

==========
Android: Add connection security summary to page info popup

This adds a short summary message to the page info popup to explain the
security state of a page, along with the existing longer description.
These strings are now generated by the same C++ code which runs on
desktop, removing the need for most of the Android-specific strings and
logic.

BUG=657148
==========

[tsergeant, 2016-11-03 04:39:23]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 04:39:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-11-03 05:52:10]

Patchset #1 (id:1) has been deleted

[tsergeant, 2016-11-03 05:52:19]

Patchset #1 (id:20001) has been deleted

[tsergeant, 2016-11-03 05:53:17]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 05:53:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-11-03 05:55:20]

tsergeant@chromium.org changed reviewers:
+ tedchoc@chromium.org

[tsergeant, 2016-11-03 05:55:20]

tedchoc@, please take a look!

There are screenshots of the change on the bug.

[commit-bot: I haz the power, 2016-11-03 07:54:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 07:54:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Ted C, 2016-11-03 20:49:48]

lgtm w/ a couple small comments

https://codereview.chromium.org/2468413002/diff/40001/chrome/android/java/res...
File chrome/android/java/res/layout/website_settings.xml (right):

https://codereview.chromium.org/2468413002/diff/40001/chrome/android/java/res...
chrome/android/java/res/layout/website_settings.xml:41:
android:lineSpacingExtra="3dp"
should this have paddingTop="16dp" here? and no paddingBottom on
website_settings_url above?

If this view is gone, you're going to be increasing the padding between the URL
and the connection message much more than it was previously.  Is that intended?

https://codereview.chromium.org/2468413002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
(right):

https://codereview.chromium.org/2468413002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java:646:
if (!summary.equals(details)) {
I would use TextUtils.equals here more so out of consistency

[tsergeant, 2016-11-03 23:01:04]

Thanks for reviewing!

https://codereview.chromium.org/2468413002/diff/40001/chrome/android/java/res...
File chrome/android/java/res/layout/website_settings.xml (right):

https://codereview.chromium.org/2468413002/diff/40001/chrome/android/java/res...
chrome/android/java/res/layout/website_settings.xml:41:
android:lineSpacingExtra="3dp"
On 2016/11/03 20:49:48, Ted C wrote:
> should this have paddingTop="16dp" here? and no paddingBottom on
> website_settings_url above?
> 
> If this view is gone, you're going to be increasing the padding between the
URL
> and the connection message much more than it was previously.  Is that
intended?

I'm not sure whether this should have the extra padding or not. I've moved it
around as you suggest, and I'll follow up with our UI designer after this lands.

https://codereview.chromium.org/2468413002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
(right):

https://codereview.chromium.org/2468413002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java:646:
if (!summary.equals(details)) {
On 2016/11/03 20:49:48, Ted C wrote:
> I would use TextUtils.equals here more so out of consistency

Done.

[tsergeant, 2016-11-03 23:01:18]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-11-03 23:01:19]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2468413002/#ps60001
(title: "Review comments")

[commit-bot: I haz the power, 2016-11-03 23:02:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 23:44:45]

Description was changed from

==========
Android: Add connection security summary to page info popup

This adds a short summary message to the page info popup to explain the
security state of a page, along with the existing longer description.
These strings are now generated by the same C++ code which runs on
desktop, removing the need for most of the Android-specific strings and
logic.

BUG=657148
==========

to

==========
Android: Add connection security summary to page info popup

This adds a short summary message to the page info popup to explain the
security state of a page, along with the existing longer description.
These strings are now generated by the same C++ code which runs on
desktop, removing the need for most of the Android-specific strings and
logic.

BUG=657148
==========

[commit-bot: I haz the power, 2016-11-03 23:44:46]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-11-03 23:48:01]

Description was changed from

==========
Android: Add connection security summary to page info popup

This adds a short summary message to the page info popup to explain the
security state of a page, along with the existing longer description.
These strings are now generated by the same C++ code which runs on
desktop, removing the need for most of the Android-specific strings and
logic.

BUG=657148
==========

to

==========
Android: Add connection security summary to page info popup

This adds a short summary message to the page info popup to explain the
security state of a page, along with the existing longer description.
These strings are now generated by the same C++ code which runs on
desktop, removing the need for most of the Android-specific strings and
logic.

BUG=657148

Committed: https://crrev.com/7ec4b62739fca0380d6de17feb58d6f537983dbe
Cr-Commit-Position: refs/heads/master@{#429729}
==========

[commit-bot: I haz the power, 2016-11-03 23:48:02]

Patchset 2 (id:??) landed as
https://crrev.com/7ec4b62739fca0380d6de17feb58d6f537983dbe
Cr-Commit-Position: refs/heads/master@{#429729}