Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: chrome/browser/ui/android/page_info/website_settings_popup_android.cc

Issue 2468413002: Android: Add connection security summary to page info popup (Closed)
Patch Set: Review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/strings/android_chrome_strings.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/android/page_info/website_settings_popup_android.cc
diff --git a/chrome/browser/ui/android/page_info/website_settings_popup_android.cc b/chrome/browser/ui/android/page_info/website_settings_popup_android.cc
index a9619451854f2bd81c2a94802643a70075407c97..ea9d941d9da0f81a5437c57c65f719ec0f63fc4b 100644
--- a/chrome/browser/ui/android/page_info/website_settings_popup_android.cc
+++ b/chrome/browser/ui/android/page_info/website_settings_popup_android.cc
@@ -81,7 +81,13 @@ void WebsiteSettingsPopupAndroid::RecordWebsiteSettingsAction(
void WebsiteSettingsPopupAndroid::SetIdentityInfo(
const IdentityInfo& identity_info) {
JNIEnv* env = base::android::AttachCurrentThread();
- Java_WebsiteSettingsPopup_showDialog(env, popup_jobject_);
+ std::unique_ptr<WebsiteSettingsUI::SecurityDescription> security_description =
+ identity_info.GetSecurityDescription();
+
+ Java_WebsiteSettingsPopup_setSecurityDescription(
+ env, popup_jobject_,
+ ConvertUTF16ToJavaString(env, security_description->summary),
+ ConvertUTF16ToJavaString(env, security_description->details));
}
void WebsiteSettingsPopupAndroid::SetCookieInfo(
« no previous file with comments | « chrome/android/java/strings/android_chrome_strings.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698