Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: chrome/browser/ui/android/page_info/website_settings_popup_android.cc

Issue 2468413002: Android: Add connection security summary to page info popup (Closed)
Patch Set: Review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/strings/android_chrome_strings.grd ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/page_info/website_settings_popup_android.h" 5 #include "chrome/browser/ui/android/page_info/website_settings_popup_android.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_array.h" 8 #include "base/android/jni_array.h"
9 #include "base/android/jni_string.h" 9 #include "base/android/jni_string.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 JNIEnv* env, 74 JNIEnv* env,
75 const JavaParamRef<jobject>& obj, 75 const JavaParamRef<jobject>& obj,
76 jint action) { 76 jint action) {
77 presenter_->RecordWebsiteSettingsAction( 77 presenter_->RecordWebsiteSettingsAction(
78 static_cast<WebsiteSettings::WebsiteSettingsAction>(action)); 78 static_cast<WebsiteSettings::WebsiteSettingsAction>(action));
79 } 79 }
80 80
81 void WebsiteSettingsPopupAndroid::SetIdentityInfo( 81 void WebsiteSettingsPopupAndroid::SetIdentityInfo(
82 const IdentityInfo& identity_info) { 82 const IdentityInfo& identity_info) {
83 JNIEnv* env = base::android::AttachCurrentThread(); 83 JNIEnv* env = base::android::AttachCurrentThread();
84 Java_WebsiteSettingsPopup_showDialog(env, popup_jobject_); 84 std::unique_ptr<WebsiteSettingsUI::SecurityDescription> security_description =
85 identity_info.GetSecurityDescription();
86
87 Java_WebsiteSettingsPopup_setSecurityDescription(
88 env, popup_jobject_,
89 ConvertUTF16ToJavaString(env, security_description->summary),
90 ConvertUTF16ToJavaString(env, security_description->details));
85 } 91 }
86 92
87 void WebsiteSettingsPopupAndroid::SetCookieInfo( 93 void WebsiteSettingsPopupAndroid::SetCookieInfo(
88 const CookieInfoList& cookie_info_list) { 94 const CookieInfoList& cookie_info_list) {
89 NOTIMPLEMENTED(); 95 NOTIMPLEMENTED();
90 } 96 }
91 97
92 void WebsiteSettingsPopupAndroid::SetPermissionInfo( 98 void WebsiteSettingsPopupAndroid::SetPermissionInfo(
93 const PermissionInfoList& permission_info_list, 99 const PermissionInfoList& permission_info_list,
94 ChosenObjectInfoList chosen_object_info_list) { 100 ChosenObjectInfoList chosen_object_info_list) {
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 WebsiteSettingsUI::TabId tab_id) { 152 WebsiteSettingsUI::TabId tab_id) {
147 // There's no tab UI on Android - only connection info is shown. 153 // There's no tab UI on Android - only connection info is shown.
148 NOTIMPLEMENTED(); 154 NOTIMPLEMENTED();
149 } 155 }
150 156
151 // static 157 // static
152 bool WebsiteSettingsPopupAndroid::RegisterWebsiteSettingsPopupAndroid( 158 bool WebsiteSettingsPopupAndroid::RegisterWebsiteSettingsPopupAndroid(
153 JNIEnv* env) { 159 JNIEnv* env) {
154 return RegisterNativesImpl(env); 160 return RegisterNativesImpl(env);
155 } 161 }
OLDNEW
« no previous file with comments | « chrome/android/java/strings/android_chrome_strings.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698