Android: Add connection security summary to page info popup

chrome/android/java/res/layout/website_settings.xml

 <?xml version="1.0" encoding="utf-8"?>
 <!--
    Copyright 2013 The Chromium Authors. All rights reserved.
 
    Use of this source code is governed by a BSD-style license that can be
    found in the LICENSE file.
 -->
 <LinearLayout
     xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:chrome="http://schemas.android.com/apk/res-auto"
@@ skipping 11 matching lines @@
         android:paddingEnd="@dimen/website_settings_popup_padding_sides"
         android:paddingStart="@dimen/website_settings_popup_padding_sides" >
 
         <view class="org.chromium.chrome.browser.pageinfo.WebsiteSettingsPopup$ElidedUrlTextView"
             android:id="@+id/website_settings_url"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:ellipsize="end"
             android:lineSpacingExtra="6dp"
             android:paddingTop="16dp"
+            android:paddingBottom="16dp"
             android:textAlignment="viewStart"
             android:textColor="@color/url_emphasis_default_text"
             android:textSize="16sp"/>
 
         <TextView
+            android:id="@+id/website_settings_connection_summary"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:lineSpacingExtra="3dp"

[Ted C, 2016/11/03 20:49:48]

should this have paddingTop="16dp" here? and no paddingBottom on
website_settings_url above?

If this view is gone, you're going to be increasing the padding between the URL
and the connection message much more than it was previously.  Is that intended?

[tsergeant, 2016/11/03 23:01:04]

I'm not sure whether this should have the extra padding or not. I've moved it
around as you suggest, and I'll follow up with our UI designer after this lands.

+            android:textColor="@color/website_settings_popup_text"
+            android:textSize="16sp"
+            android:visibility="gone" />
+
+        <TextView
             android:id="@+id/website_settings_connection_message"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:lineSpacingExtra="3dp"
             android:paddingTop="8dp"
             android:textColor="@color/website_settings_popup_text"
             android:textSize="14sp" />
     </LinearLayout>
 
     <org.chromium.ui.widget.ButtonCompat
@@ skipping 43 matching lines @@
         android:layout_gravity="end"
         android:layout_marginEnd="@dimen/website_settings_popup_padding_sides"
         android:layout_marginStart="@dimen/website_settings_popup_padding_sides"
         android:layout_marginTop="8dp"
         android:paddingEnd="@dimen/website_settings_popup_button_padding_sides"
         android:paddingStart="@dimen/website_settings_popup_button_padding_sides"
         android:text="@string/page_info_open_online_button"
         android:textColor="@color/light_active_color"
         style="@style/ButtonCompatBorderless" />
 </LinearLayout>