Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2468133002: [SubZero] Fix code generation for vector type (Closed)

Created:
4 years, 1 month ago by jaydeep.patil
Modified:
4 years, 1 month ago
CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[SubZero] Fix code generation for vector type The patch fixes legalizeToReg issues in vector code generation. The patch also generates JALR for pointer to function and corrects encoding of FP conditional move instruction. R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=0c4c07d0d83aedf38f0529ecc2337ccfa5a18ba6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6805 lines, -5893 lines) Patch
M src/IceAssemblerMIPS32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceAssemblerMIPS32.cpp View 2 chunks +13 lines, -2 lines 0 comments Download
M src/IceInstMIPS32.cpp View 2 chunks +7 lines, -4 lines 0 comments Download
M src/IceTargetLoweringMIPS32.cpp View 11 chunks +32 lines, -18 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-arg.ll View 1 chunk +4 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-cast.ll View 40 chunks +96 lines, -48 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-icmp.ll View 52 chunks +5888 lines, -5215 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-select.ll View 7 chunks +763 lines, -603 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jaydeep.patil
4 years, 1 month ago (2016-11-02 04:43:16 UTC) #3
Jim Stichnoth
lgtm
4 years, 1 month ago (2016-11-02 06:53:43 UTC) #4
Jim Stichnoth
4 years, 1 month ago (2016-11-02 06:53:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c4c07d0d83aedf38f0529ecc2337ccfa5a18ba6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698