Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2466383004: blink: Cleanup class forward declarations (Closed)

Created:
4 years, 1 month ago by jbriance
Modified:
4 years, 1 month ago
Reviewers:
haraken
CC:
chromium-reviews, serviceworker-reviews, blink-reviews-platform-graphics_chromium.org, tzik, mlamouri+watch-screen-orientation_chromium.org, dshwang, leviw+bidiwatch_chromium.org, eric.carlson_apple.com, scheib+watch_chromium.org, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, Mads Ager (chromium), Srirama, toyoshim+midi_chromium.org, kinuko+watch, blink-reviews-wtf_chromium.org, rwlbuis, timvolodine, jsbell+serviceworker_chromium.org, caseq+blink_chromium.org, krit, drott+blinkwatch_chromium.org, blink-reviews-style_chromium.org, aboxhall, mvanouwerkerk+watch_chromium.org, aboxhall+watch_chromium.org, blink-reviews-css, iclelland+watch_chromium.org, chasej+watch_chromium.org, Justin Novosad, hongchan, nhiroki, mlamouri+watch-blink_chromium.org, dglazkov+blink, je_julie, blink-reviews-bindings_chromium.org, jkarlin+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, f(malita), falken+watch_chromium.org, ajuma+watch_chromium.org, mcasas+watch+mediastream_chromium.org, Eric Willigers, rjwright, cmumford, darktears, Peter Beverloo, blink-reviews-paint_chromium.org, jbroman, lushnikov+blink_chromium.org, Raymond Toy, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, dmazzoni, yuzo+watch_chromium.org, jbroman+watch_chromium.org, haraken, piman+watch_chromium.org, jsbell+idb_chromium.org, Stephen Chennney, yhirano+watch_chromium.org, michaeln, shimazu+serviceworker_chromium.org, tyoshino+watch_chromium.org, Rik, ajuma+watch-canvas_chromium.org, scheduler-bugs_chromium.org, horo+watch_chromium.org, nektar+watch_chromium.org, pdr+graphicswatchlist_chromium.org, blink-layers+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, shans, kinuko+serviceworker, dtseng+watch_chromium.org, blink-reviews-animation_chromium.org, oilpan-reviews, ortuno+watch_chromium.org, danakj+watch_chromium.org, Mikhail, kouhei+heap_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blink: Cleanup class forward declarations Remove useless class forward declarations and add missing ones in blink header files. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/ed420fd7e6e7f2a8bf971916134683580383dd83 Cr-Commit-Position: refs/heads/master@{#429315}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -205 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptController.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserObserver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/Performance.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/EventTargetModules.h View 1 chunk +0 lines, -9 lines 2 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableColumn.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/background_sync/SyncCallbacks.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/budget/BudgetState.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasStyle.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/ClipList.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeyStatusMap.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Body.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchRequestData.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Headers.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/Geolocation.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBAny.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/NavigatorMediaStream.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaRequest.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionErrorCallback.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/permissions/Permissions.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationController.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorReading.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/InstallEvent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/vibration/VibrationController.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h View 3 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 4 chunks +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIInputMap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIOutputMap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Widget.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/CustomFontData.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontFallbackIterator.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontPlatformData.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResultInlineHeaders.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/BoxReflection.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/FrameData.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/CullRect.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/GarbageCollected.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/TraceTraits.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Visitor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamCenter.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/ContentSecurityPolicyParsers.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/time_domain.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/work_queue_sets.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimator.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/BidiResolver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/CompositorMutatorImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/UserMediaClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Forward.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/VectorTraits.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
jbriance
Following https://codereview.chromium.org/2460243002/ and https://codereview.chromium.org/2463703003/, removing more unused forward class declarations in all blink header files. ...
4 years, 1 month ago (2016-11-02 14:06:47 UTC) #4
haraken
LGTM https://codereview.chromium.org/2466383004/diff/1/third_party/WebKit/Source/modules/EventTargetModules.h File third_party/WebKit/Source/modules/EventTargetModules.h (right): https://codereview.chromium.org/2466383004/diff/1/third_party/WebKit/Source/modules/EventTargetModules.h#newcode12 third_party/WebKit/Source/modules/EventTargetModules.h:12: #endif // EventTargetModules_h Oh... this is an include-only ...
4 years, 1 month ago (2016-11-02 14:57:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2466383004/1
4 years, 1 month ago (2016-11-02 17:16:16 UTC) #11
jbriance
Removing jochen from reviewer list (added in first place because I read OWNERS files too ...
4 years, 1 month ago (2016-11-02 17:22:47 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 17:23:11 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ed420fd7e6e7f2a8bf971916134683580383dd83 Cr-Commit-Position: refs/heads/master@{#429315}
4 years, 1 month ago (2016-11-02 17:56:23 UTC) #16
jbriance
4 years, 1 month ago (2016-11-03 22:16:29 UTC) #17
Message was sent while issue was closed. 
Meta bug created: https://bugs.chromium.org/p/chromium/issues/detail?id=662195

Powered by Google App Engine
This is Rietveld 408576698